You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/08 15:51:59 UTC

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8753: [WIP][Not ready for review] Streamed segment download & untar with rate limiter to control disk usage `feature`

siddharthteotia commented on code in PR #8753:
URL: https://github.com/apache/pinot/pull/8753#discussion_r892559121


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -1004,6 +1004,25 @@ public int downloadFile(URI uri, File dest, AuthProvider authProvider, List<Head
     return _httpClient.downloadFile(uri, HttpClient.DEFAULT_SOCKET_TIMEOUT_MS, dest, authProvider, httpHeaders);
   }
 
+  /**
+   * Download and untar a file.

Review Comment:
   (nit) Please add few more sentences about this method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org