[GitHub] [superset] rijojoseph07 commented on pull request #13214: fix: Changes to support presto impersionation with ldap

[GitBox <gi...@apache.org>]

rijojoseph07 commented on pull request #13214:
URL: https://github.com/apache/superset/pull/13214#issuecomment-781932852


   > @rijojoseph07 would it be add to add a test duplicating the bug to both verify the fix and prevent future regressions?
   
   @willbarrett I am trying to write a unit test for this but struggling to get connect_params from the SQLAlchemy engine object to check if the new `principal_username` is added. 
   
   I have tested this code in our environment and is running in our prod system. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org