You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/02/18 09:36:29 UTC
[GitHub] flink pull request: [FLINK-3432] Fixed ZookeeperOffsethandlerTest ...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1664
[FLINK-3432] Fixed ZookeeperOffsethandlerTest on Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3425_test_failure_6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1664
----
commit d5774fc3c092520685073ca64f192d6a0ca72d62
Author: zentol <s....@web.de>
Date: 2016-02-18T08:36:23Z
[FLINK-3432] Fixed ZookeeperOffsethandlerTest on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3432] Fixed ZookeeperOffsethandlerTest ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1664#issuecomment-191814477
Will merge it. Thanks for your contribution @zentol :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3432] Fixed ZookeeperOffsethandlerTest ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3432] Fixed ZookeeperOffsethandlerTest ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1664#issuecomment-188911039
Looks good to my, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3432] Fixed ZookeeperOffsethandlerTest ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1664#issuecomment-185741473
The mkdirs() command failed for me on Windows. While debugging i noticed that mkdirs provides no means of accessing the reason why it failed. Files.createDirectories() is supposed to be more explicit with errors, and ,surprisingly enough, succeeded where mkdirs failed right away.
During the failure i also got an NullPointerException in close() since brokers wasn't initialized, so i added a null check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---