You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2023/01/15 03:45:38 UTC

[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1225: Fix error message passing in Server::Start

tisonkun commented on code in PR #1225:
URL: https://github.com/apache/incubator-kvrocks/pull/1225#discussion_r1070494895


##########
src/main.cc:
##########
@@ -319,8 +319,7 @@ int main(int argc, char *argv[]) {
     uint32_t ports[] = {config.port, config.tls_port, 0};
     for (uint32_t *port = ports; *port; ++port) {
       if (Util::IsPortInUse(*port)) {
-        LOG(ERROR) << "Could not create server TCP since the specified port[" << *port << "] is already in use"
-                   << std::endl;
+        LOG(ERROR) << "Could not create server TCP since the specified port[" << *port << "] is already in use";

Review Comment:
   Does LOG already append endl?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org