You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/26 15:31:06 UTC
[GitHub] [camel-kafka-connector] fvaleri opened a new pull request #336: Add CORE protocol support to SJMS2 connector
fvaleri opened a new pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336
I would be good to also support the CORE protocol with the SJMS2 connector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd merged pull request #336: Add CORE protocol support to SJMS2 connector
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on a change in pull request #336: Add CORE protocol support to SJMS2 connector
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336#discussion_r460735899
##########
File path: connectors/camel-sjms2-kafka-connector/pom.xml
##########
@@ -48,7 +48,10 @@
<dependency>
<groupId>org.apache.activemq</groupId>
<artifactId>activemq-client</artifactId>
- <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client</artifactId>
Review comment:
Got you, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] fvaleri commented on pull request #336: Add CORE protocol support to SJMS2 connector
Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336#issuecomment-664146996
Tested with [this example](https://github.com/fvaleri/cdc/tree/master/connect-cdc) changing the `camel.component.sjms2.connection-factory` to `#class:org.apache.activemq.ActiveMQConnectionFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] fvaleri commented on a change in pull request #336: Add CORE protocol support to SJMS2 connector
Posted by GitBox <gi...@apache.org>.
fvaleri commented on a change in pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336#discussion_r460728165
##########
File path: connectors/camel-sjms2-kafka-connector/pom.xml
##########
@@ -48,7 +48,10 @@
<dependency>
<groupId>org.apache.activemq</groupId>
<artifactId>activemq-client</artifactId>
- <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client</artifactId>
Review comment:
Nope, unfortunately only Artemis CORE. To support OpenWire, AMQP and CORE we need three distinct dependencies. Defaulting to OpenWire (activemq-client) is good because the connector works with both ActiveMQ and Artemis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on a change in pull request #336: Add CORE protocol support to SJMS2 connector
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336#discussion_r460723806
##########
File path: connectors/camel-sjms2-kafka-connector/pom.xml
##########
@@ -48,7 +48,10 @@
<dependency>
<groupId>org.apache.activemq</groupId>
<artifactId>activemq-client</artifactId>
- <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client</artifactId>
Review comment:
Is this client capable of all protocols that `activemq-client` support? In other words can we use just this dependences and get rid of `activemq-client`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on a change in pull request #336: Add CORE protocol support to SJMS2 connector
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336#discussion_r460567204
##########
File path: docs/modules/ROOT/pages/connectors.adoc
##########
@@ -71,6 +71,7 @@ Number of Camel Kafka connectors: 351
| *camel-bean-kafka-connector* | true | false | xref:connectors/camel-bean-kafka-sink-connector.adoc[Sink Docs] | | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-bean-kafka-connector/0.3.0/camel-bean-kafka-connector-0.3.0-package.zip[Download Zip] | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-bean-kafka-connector/0.3.0/camel-bean-kafka-connector-0.3.0-package.tar.gz[Download Tar.gz]
| *camel-bean-validator-kafka-connector* | true | false | xref:connectors/camel-bean-validator-kafka-sink-connector.adoc[Sink Docs] | | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-bean-validator-kafka-connector/0.3.0/camel-bean-validator-kafka-connector-0.3.0-package.zip[Download Zip] | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-bean-validator-kafka-connector/0.3.0/camel-bean-validator-kafka-connector-0.3.0-package.tar.gz[Download Tar.gz]
| *camel-beanstalk-kafka-connector* | true | true | xref:connectors/camel-beanstalk-kafka-sink-connector.adoc[Sink Docs] | xref:connectors/camel-beanstalk-kafka-source-connector.adoc[Source Docs] | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-beanstalk-kafka-connector/0.3.0/camel-beanstalk-kafka-connector-0.3.0-package.zip[Download Zip] | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-beanstalk-kafka-connector/0.3.0/camel-beanstalk-kafka-connector-0.3.0-package.tar.gz[Download Tar.gz]
+| *camel-bonita-kafka-connector* | true | false | xref:connectors/camel-bonita-kafka-sink-connector.adoc[Sink Docs] | | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-bonita-kafka-connector/0.3.0/camel-bonita-kafka-connector-0.3.0-package.zip[Download Zip] | https://repo.maven.apache.org/maven2/org/apache/camel/kafkaconnector/camel-bonita-kafka-connector/0.3.0/camel-bonita-kafka-connector-0.3.0-package.tar.gz[Download Tar.gz]
Review comment:
Bonita has been removed
##########
File path: parent/pom.xml
##########
@@ -287,6 +287,12 @@
<version>${activemq-version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
If this is used only in the tests for sums it makes sense to add the dependency only in the specific test folder and not in parent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org