You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2024/02/08 08:42:41 UTC

(james-project) 02/03: JAMES-3981 Warn upon invalid RCPT

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 6fdf4987935ee2708ac5f8b0ed66637f45e1295b
Author: Benoit TELLIER <bt...@linagora.com>
AuthorDate: Tue Feb 6 16:48:36 2024 +0100

    JAMES-3981 Warn upon invalid RCPT
    
    Not a critical issue but rather a warning
---
 .../protocols/smtp/core/fastfail/AbstractValidRcptHandler.java     | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/AbstractValidRcptHandler.java b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/AbstractValidRcptHandler.java
index 703a499c6c..8f9a043372 100644
--- a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/AbstractValidRcptHandler.java
+++ b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/AbstractValidRcptHandler.java
@@ -47,6 +47,13 @@ public abstract class AbstractValidRcptHandler implements RcptHook {
                 return reject(rcpt);
             }
             return HookResult.DECLINED;
+        } catch (IllegalAccessException e) {
+            LOGGER.warn("Encounter an error upon RCPT validation ({}), deny-soft", rcpt.asString());
+            return HookResult.builder()
+                .hookReturnCode(HookReturnCode.deny())
+                .smtpReturnCode(SMTPRetCode.SYNTAX_ERROR_ARGUMENTS)
+                .smtpDescription(DSNStatus.getStatus(DSNStatus.PERMANENT, DSNStatus.DELIVERY_SYNTAX) + " Unexpected error for " + rcpt.asString())
+                .build();
         } catch (Exception e) {
             LOGGER.error("Encounter an error upon RCPT validation ({}), deny-soft", rcpt.asString(), e);
             return HookResult.builder()


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org