You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/21 17:08:29 UTC
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9678: IGNITE-13359 .NET: Add GetServiceDescriptor
ptupitsyn commented on a change in pull request #9678:
URL: https://github.com/apache/ignite/pull/9678#discussion_r773305627
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IServicesClient.cs
##########
@@ -38,6 +40,19 @@ public interface IServicesClient
/// <returns>Proxy object that forwards all member calls to a remote Ignite service.</returns>
T GetServiceProxy<T>(string serviceName) where T : class;
+ /// <summary>
+ /// Gets metadata about all deployed services in the grid.
+ /// </summary>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ ICollection<IClientServiceDescriptor> GetServiceDescriptors();
+
+ /// <summary>
+ /// Gets metadata about service deployed in the grid.
+ /// </summary>
+ /// <param name="serviceName">Service name</param>
Review comment:
```suggestion
/// <param name="serviceName">Service name.</param>
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ClientServiceDescriptor.cs
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Client.Services
+{
+ using System;
+ using Apache.Ignite.Core.Binary;
+ using Apache.Ignite.Core.Client.Services;
+
+ /// <summary>
+ /// Implementation of client service descriptor.
+ /// </summary>
+ public class ClientServiceDescriptor : IClientServiceDescriptor
+ {
+ /// <summary>
+ /// Constructor
Review comment:
```suggestion
/// Initializes a new instance of the <see cref="ClientServiceDescriptor" /> class.
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ClientServiceDescriptor.cs
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Client.Services
+{
+ using System;
+ using Apache.Ignite.Core.Binary;
+ using Apache.Ignite.Core.Client.Services;
+
+ /// <summary>
+ /// Implementation of client service descriptor.
+ /// </summary>
+ public class ClientServiceDescriptor : IClientServiceDescriptor
Review comment:
```suggestion
internal class ClientServiceDescriptor : IClientServiceDescriptor
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ClientServiceDescriptor.cs
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Client.Services
+{
+ using System;
+ using Apache.Ignite.Core.Binary;
+ using Apache.Ignite.Core.Client.Services;
+
+ /// <summary>
+ /// Implementation of client service descriptor.
+ /// </summary>
+ public class ClientServiceDescriptor : IClientServiceDescriptor
+ {
+ /// <summary>
+ /// Constructor
+ /// </summary>
+ /// <param name="reader">Reader</param>
Review comment:
```suggestion
/// <param name="reader">Reader.</param>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org