You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/05/11 08:02:23 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
kasjer opened a new pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591
This is based on NRF52 but incorporates changes needed
to handle NRF5340 MCU.
Name of driver implies that it used Nordic provided NRFX code.
This driver can be used in NRF52 MCUs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591#issuecomment-840416847
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/nordic/nrf5340/include/nrfx_config.h
<details>
```diff
@@ -150,755 +150,869 @@
#define NRF_QDEC NRF_QDEC0
#define QDEC_IRQHandler QDEC0_IRQHandler
-// <<< Use Configuration Wizard in Context Menu >>>\n
-
-// <h> nRF_Drivers
-
-// <e> NRFX_CLOCK_ENABLED - nrfx_clock - CLOCK peripheral driver.
-//==========================================================
+/* <<< Use Configuration Wizard in Context Menu >>>\n */
+
+/* <h> nRF_Drivers */
+
+/*
+ <e> NRFX_CLOCK_ENABLED - nrfx_clock - CLOCK peripheral driver.
+ ==========================================================
+ */
#ifndef NRFX_CLOCK_ENABLED
#define NRFX_CLOCK_ENABLED 0
#endif
-// <o> NRFX_CLOCK_CONFIG_LF_SRC - LF clock source.
-
-// <0=> ULP
-// <1=> RC
-// <2=> XTAL
-// <3=> Synth
+/* <o> NRFX_CLOCK_CONFIG_LF_SRC - LF clock source. */
+
+/*
+ <0=> ULP
+ <1=> RC
+ <2=> XTAL
+ <3=> Synth
+ */
#ifndef NRFX_CLOCK_CONFIG_LF_SRC
#define NRFX_CLOCK_CONFIG_LF_SRC 2
#endif
-// <q> NRFX_CLOCK_CONFIG_LF_CAL_ENABLED - Enables LF Clock Calibration Support
+/* <q> NRFX_CLOCK_CONFIG_LF_CAL_ENABLED - Enables LF Clock Calibration Support */
#ifndef NRFX_CLOCK_CONFIG_LF_CAL_ENABLED
#define NRFX_CLOCK_CONFIG_LF_CAL_ENABLED 0
#endif
-// <o> NRFX_CLOCK_CONFIG_HFCLK192M_SRC - HFCLK192M source.
-
-// <0=> HFINT
-// <1=> HFXO
+/* <o> NRFX_CLOCK_CONFIG_HFCLK192M_SRC - HFCLK192M source. */
+
+/*
+ <0=> HFINT
+ <1=> HFXO
+ */
#ifndef NRFX_CLOCK_CONFIG_HFCLK192M_SRC
#define NRFX_CLOCK_CONFIG_HFCLK192M_SRC 1
#endif
-// <o> NRFX_CLOCK_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority.
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_CLOCK_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority. */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_CLOCK_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_CLOCK_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <e> NRFX_CLOCK_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_CLOCK_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_CLOCK_CONFIG_LOG_ENABLED
#define NRFX_CLOCK_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_CLOCK_CONFIG_LOG_LEVEL - Default severity level.
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_CLOCK_CONFIG_LOG_LEVEL - Default severity level. */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_CLOCK_CONFIG_LOG_LEVEL
#define NRFX_CLOCK_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_CLOCK_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_CLOCK_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_CLOCK_CONFIG_INFO_COLOR
#define NRFX_CLOCK_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_CLOCK_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_CLOCK_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_CLOCK_CONFIG_DEBUG_COLOR
#define NRFX_CLOCK_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_COMP_ENABLED - nrfx_comp - COMP peripheral driver
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_COMP_ENABLED - nrfx_comp - COMP peripheral driver
+ ==========================================================
+ */
#ifndef NRFX_COMP_ENABLED
#define NRFX_COMP_ENABLED 0
#endif
-// <o> NRFX_COMP_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_COMP_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_COMP_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_COMP_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <e> NRFX_COMP_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_COMP_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_COMP_CONFIG_LOG_ENABLED
#define NRFX_COMP_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_COMP_CONFIG_LOG_LEVEL - Default Severity level
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_COMP_CONFIG_LOG_LEVEL - Default Severity level */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_COMP_CONFIG_LOG_LEVEL
#define NRFX_COMP_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_COMP_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_COMP_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_COMP_CONFIG_INFO_COLOR
#define NRFX_COMP_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_COMP_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_COMP_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_COMP_CONFIG_DEBUG_COLOR
#define NRFX_COMP_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_DPPI_ENABLED - nrfx_dppi - DPPI allocator.
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_DPPI_ENABLED - nrfx_dppi - DPPI allocator.
+ ==========================================================
+ */
#ifndef NRFX_DPPI_ENABLED
#define NRFX_DPPI_ENABLED 0
#endif
-// <e> NRFX_DPPI_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_DPPI_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_DPPI_CONFIG_LOG_ENABLED
#define NRFX_DPPI_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_DPPI_CONFIG_LOG_LEVEL - Default severity level.
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_DPPI_CONFIG_LOG_LEVEL - Default severity level. */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_DPPI_CONFIG_LOG_LEVEL
#define NRFX_DPPI_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_DPPI_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_DPPI_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_DPPI_CONFIG_INFO_COLOR
#define NRFX_DPPI_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_DPPI_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_DPPI_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_DPPI_CONFIG_DEBUG_COLOR
#define NRFX_DPPI_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_EGU_ENABLED - nrfx_egu - EGU peripheral driver.
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_EGU_ENABLED - nrfx_egu - EGU peripheral driver.
+ ==========================================================
+ */
#ifndef NRFX_EGU_ENABLED
#define NRFX_EGU_ENABLED 0
#endif
-// <q> NRFX_EGU0_ENABLED - Enable EGU0 instance.
+/* <q> NRFX_EGU0_ENABLED - Enable EGU0 instance. */
#ifndef NRFX_EGU0_ENABLED
#define NRFX_EGU0_ENABLED 0
#endif
-// <q> NRFX_EGU1_ENABLED - Enable EGU1 instance.
+/* <q> NRFX_EGU1_ENABLED - Enable EGU1 instance. */
#ifndef NRFX_EGU1_ENABLED
#define NRFX_EGU1_ENABLED 0
#endif
-// <q> NRFX_EGU2_ENABLED - Enable EGU2 instance.
+/* <q> NRFX_EGU2_ENABLED - Enable EGU2 instance. */
#ifndef NRFX_EGU2_ENABLED
#define NRFX_EGU2_ENABLED 0
#endif
-// <q> NRFX_EGU3_ENABLED - Enable EGU3 instance.
+/* <q> NRFX_EGU3_ENABLED - Enable EGU3 instance. */
#ifndef NRFX_EGU3_ENABLED
#define NRFX_EGU3_ENABLED 0
#endif
-// <q> NRFX_EGU4_ENABLED - Enable EGU4 instance.
+/* <q> NRFX_EGU4_ENABLED - Enable EGU4 instance. */
#ifndef NRFX_EGU4_ENABLED
#define NRFX_EGU4_ENABLED 0
#endif
-// <q> NRFX_EGU5_ENABLED - Enable EGU5 instance.
+/* <q> NRFX_EGU5_ENABLED - Enable EGU5 instance. */
#ifndef NRFX_EGU5_ENABLED
#define NRFX_EGU5_ENABLED 0
#endif
-// <o> NRFX_EGU_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority.
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_EGU_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority. */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_EGU_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_EGU_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// </e>
-
-// <e> NRFX_GPIOTE_ENABLED - nrfx_gpiote - GPIOTE peripheral driver.
-//==========================================================
+/* </e> */
+
+/*
+ <e> NRFX_GPIOTE_ENABLED - nrfx_gpiote - GPIOTE peripheral driver.
+ ==========================================================
+ */
#ifndef NRFX_GPIOTE_ENABLED
#define NRFX_GPIOTE_ENABLED 0
#endif
-// <o> NRFX_GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS - Number of lower power input pins.
+/* <o> NRFX_GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS - Number of lower power input pins. */
#ifndef NRFX_GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS
#define NRFX_GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS 1
#endif
-// <o> NRFX_GPIOTE_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority.
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_GPIOTE_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority. */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_GPIOTE_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_GPIOTE_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <e> NRFX_GPIOTE_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_GPIOTE_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_GPIOTE_CONFIG_LOG_ENABLED
#define NRFX_GPIOTE_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_GPIOTE_CONFIG_LOG_LEVEL - Default severity level.
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_GPIOTE_CONFIG_LOG_LEVEL - Default severity level. */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_GPIOTE_CONFIG_LOG_LEVEL
#define NRFX_GPIOTE_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_GPIOTE_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_GPIOTE_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_GPIOTE_CONFIG_INFO_COLOR
#define NRFX_GPIOTE_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_GPIOTE_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_GPIOTE_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_GPIOTE_CONFIG_DEBUG_COLOR
#define NRFX_GPIOTE_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_I2S_ENABLED - nrfx_i2s - I2S peripheral driver.
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_I2S_ENABLED - nrfx_i2s - I2S peripheral driver.
+ ==========================================================
+ */
#ifndef NRFX_I2S_ENABLED
#define NRFX_I2S_ENABLED 1
#endif
-// <o> NRFX_I2S_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority.
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_I2S_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority. */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_I2S_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_I2S_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <e> NRFX_I2S_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_I2S_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_I2S_CONFIG_LOG_ENABLED
#define NRFX_I2S_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_I2S_CONFIG_LOG_LEVEL - Default severity level.
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_I2S_CONFIG_LOG_LEVEL - Default severity level. */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_I2S_CONFIG_LOG_LEVEL
#define NRFX_I2S_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_I2S_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_I2S_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_I2S_CONFIG_INFO_COLOR
#define NRFX_I2S_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_I2S_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_I2S_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_I2S_CONFIG_DEBUG_COLOR
#define NRFX_I2S_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_IPC_ENABLED - nrfx_ipc - IPC peripheral driver
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_IPC_ENABLED - nrfx_ipc - IPC peripheral driver
+ ==========================================================
+ */
#ifndef NRFX_IPC_ENABLED
#define NRFX_IPC_ENABLED 0
#endif
-// </e>
-
-// <e> NRFX_LPCOMP_ENABLED - nrfx_lpcomp - LPCOMP peripheral driver
-//==========================================================
+/* </e> */
+
+/*
+ <e> NRFX_LPCOMP_ENABLED - nrfx_lpcomp - LPCOMP peripheral driver
+ ==========================================================
+ */
#ifndef NRFX_LPCOMP_ENABLED
#define NRFX_LPCOMP_ENABLED 0
#endif
-// <o> NRFX_LPCOMP_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_LPCOMP_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_LPCOMP_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_LPCOMP_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <e> NRFX_LPCOMP_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_LPCOMP_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_LPCOMP_CONFIG_LOG_ENABLED
#define NRFX_LPCOMP_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_LPCOMP_CONFIG_LOG_LEVEL - Default Severity level
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_LPCOMP_CONFIG_LOG_LEVEL - Default Severity level */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_LPCOMP_CONFIG_LOG_LEVEL
#define NRFX_LPCOMP_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_LPCOMP_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_LPCOMP_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_LPCOMP_CONFIG_INFO_COLOR
#define NRFX_LPCOMP_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_LPCOMP_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_LPCOMP_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_LPCOMP_CONFIG_DEBUG_COLOR
#define NRFX_LPCOMP_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_NFCT_ENABLED - nrfx_nfct - NFCT peripheral driver
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_NFCT_ENABLED - nrfx_nfct - NFCT peripheral driver
+ ==========================================================
+ */
#ifndef NRFX_NFCT_ENABLED
#define NRFX_NFCT_ENABLED 0
#endif
-// <o> NRFX_NFCT_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_NFCT_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_NFCT_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_NFCT_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <o> NRFX_NFCT_CONFIG_TIMER_INSTANCE_ID - Timer instance used for workarounds in the driver.
-
-// <0=> 0
-// <1=> 1
-// <2=> 2
+/* <o> NRFX_NFCT_CONFIG_TIMER_INSTANCE_ID - Timer instance used for workarounds in the driver. */
+
+/*
+ <0=> 0
+ <1=> 1
+ <2=> 2
+ */
#ifndef NRFX_NFCT_CONFIG_TIMER_INSTANCE_ID
#define NRFX_NFCT_CONFIG_TIMER_INSTANCE_ID 2
#endif
-// <e> NRFX_NFCT_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_NFCT_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_NFCT_CONFIG_LOG_ENABLED
#define NRFX_NFCT_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_NFCT_CONFIG_LOG_LEVEL - Default Severity level
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_NFCT_CONFIG_LOG_LEVEL - Default Severity level */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_NFCT_CONFIG_LOG_LEVEL
#define NRFX_NFCT_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_NFCT_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_NFCT_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_NFCT_CONFIG_INFO_COLOR
#define NRFX_NFCT_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_NFCT_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_NFCT_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_NFCT_CONFIG_DEBUG_COLOR
#define NRFX_NFCT_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_NVMC_ENABLED - nrfx_nvmc - NVMC peripheral driver
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_NVMC_ENABLED - nrfx_nvmc - NVMC peripheral driver
+ ==========================================================
+ */
#ifndef NRFX_NVMC_ENABLED
#define NRFX_NVMC_ENABLED 0
#endif
-// </e>
-
-// <e> NRFX_PDM_ENABLED - nrfx_pdm - PDM peripheral driver.
-//==========================================================
+/* </e> */
+
+/*
+ <e> NRFX_PDM_ENABLED - nrfx_pdm - PDM peripheral driver.
+ ==========================================================
+ */
#ifndef NRFX_PDM_ENABLED
#define NRFX_PDM_ENABLED 0
#endif
-// <o> NRFX_PDM_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority.
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_PDM_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority. */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_PDM_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_PDM_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// <e> NRFX_PDM_CONFIG_LOG_ENABLED - Enables logging in the module.
-//==========================================================
+/*
+ <e> NRFX_PDM_CONFIG_LOG_ENABLED - Enables logging in the module.
+ ==========================================================
+ */
#ifndef NRFX_PDM_CONFIG_LOG_ENABLED
#define NRFX_PDM_CONFIG_LOG_ENABLED 0
#endif
-// <o> NRFX_PDM_CONFIG_LOG_LEVEL - Default severity level.
-
-// <0=> Off
-// <1=> Error
-// <2=> Warning
-// <3=> Info
-// <4=> Debug
+/* <o> NRFX_PDM_CONFIG_LOG_LEVEL - Default severity level. */
+
+/*
+ <0=> Off
+ <1=> Error
+ <2=> Warning
+ <3=> Info
+ <4=> Debug
+ */
#ifndef NRFX_PDM_CONFIG_LOG_LEVEL
#define NRFX_PDM_CONFIG_LOG_LEVEL 3
#endif
-// <o> NRFX_PDM_CONFIG_INFO_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_PDM_CONFIG_INFO_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_PDM_CONFIG_INFO_COLOR
#define NRFX_PDM_CONFIG_INFO_COLOR 0
#endif
-// <o> NRFX_PDM_CONFIG_DEBUG_COLOR - ANSI escape code prefix.
-
-// <0=> Default
-// <1=> Black
-// <2=> Red
-// <3=> Green
-// <4=> Yellow
-// <5=> Blue
-// <6=> Magenta
-// <7=> Cyan
-// <8=> White
+/* <o> NRFX_PDM_CONFIG_DEBUG_COLOR - ANSI escape code prefix. */
+
+/*
+ <0=> Default
+ <1=> Black
+ <2=> Red
+ <3=> Green
+ <4=> Yellow
+ <5=> Blue
+ <6=> Magenta
+ <7=> Cyan
+ <8=> White
+ */
#ifndef NRFX_PDM_CONFIG_DEBUG_COLOR
#define NRFX_PDM_CONFIG_DEBUG_COLOR 0
#endif
-// </e>
-
-// </e>
-
-// <e> NRFX_POWER_ENABLED - nrfx_power - POWER peripheral driver.
-//==========================================================
+/* </e> */
+
+/* </e> */
+
+/*
+ <e> NRFX_POWER_ENABLED - nrfx_power - POWER peripheral driver.
+ ==========================================================
+ */
#ifndef NRFX_POWER_ENABLED
#define NRFX_POWER_ENABLED 0
#endif
-// <o> NRFX_POWER_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority.
-
-// <0=> 0 (highest)
-// <1=> 1
-// <2=> 2
-// <3=> 3
-// <4=> 4
-// <5=> 5
-// <6=> 6
-// <7=> 7
+/* <o> NRFX_POWER_DEFAULT_CONFIG_IRQ_PRIORITY - Interrupt priority. */
+
+/*
+ <0=> 0 (highest)
+ <1=> 1
+ <2=> 2
+ <3=> 3
+ <4=> 4
+ <5=> 5
+ <6=> 6
+ <7=> 7
+ */
#ifndef NRFX_POWER_DEFAULT_CONFIG_IRQ_PRIORITY
#define NRFX_POWER_DEFAULT_CONFIG_IRQ_PRIORITY 7
#endif
-// </e>
-
-// <e> NRFX_PRS_ENABLED - nrfx_prs - Peripheral Resource Sharing (PRS) module.
-//==========================================================
+/* </e> */
+
+/*
+ <e> NRFX_PRS_ENABLED - nrfx_prs - Peripheral Resource Sharing (PRS) module.
+ ==========================================================
+ */
#ifndef NRFX_PRS_ENABLED
#define NRFX_PRS_ENABLED 0
#endif
-// <q> NRFX_PRS_BOX_0_ENABLED - Enables box 0 in the module.
+/* <q> NRFX_PRS_BOX_0_ENABLED - Enables box 0 in the module. */
#ifndef NRFX_PRS_BOX_0_ENABLED
#define NRFX_PRS_BOX_0_ENABLED 0
#endif
-// <q> NRFX_PRS_BOX_1_ENABLED - Enables box 1 in the module.
+/* <q> NRFX_PRS_BOX_1_ENABLED - Enables box 1 in the module. */
#ifndef NRFX_PRS_BOX_1_ENABLED
#define NRFX_PRS_BOX_1_ENABLED 0
#endif
-// <q> NRFX_PRS_BOX_2_ENABLED - Enables box 2 in the module.
+/* <q> NRFX_PRS_BOX_2_ENABLED - Enables box 2 in the module. */
#ifndef NRFX_PRS_BOX_2_ENABLED
#define NRFX_PRS_BOX_2_ENABLED 0
#endif
-// <q> NRFX_PRS_BOX_3_ENABLED - Enables box 3 in the module.
+/* <q> NRFX_PRS_BOX_3_ENABLED - Enables box 3 in the module. */
#ifndef NRFX_PRS_BOX_3_ENABLED
#define NRFX_PRS_BOX_3_ENABLED 0
#endif
-// <q> NRFX_PRS_BOX_4_ENABLED - Enables box 4 in the module.
+/* <q> NRFX_PRS_BOX_4_ENABLED - Enables box 4 in the module. */
#ifndef NRFX_PRS_BOX_4_ENABLED
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591#issuecomment-840407690
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on a change in pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
utzig commented on a change in pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591#discussion_r630025467
##########
File path: hw/drivers/i2s/i2s_nrfx/src/i2s_nrfx.c
##########
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <os/mynewt.h>
+#include <bsp/bsp.h>
+#include <i2s/i2s.h>
+#include <i2s/i2s_driver.h>
+#include <i2s_nrfx/i2s_nrfx.h>
+#include <nrfx/drivers/include/nrfx_i2s.h>
+
+struct i2s_nrfx {
+ nrfx_i2s_config_t nrfx_i2s_cfg;
+ bool running;
+ int8_t nrfx_queued_count;
+ struct i2s *i2s;
+ struct i2s_sample_buffer *nrfx_buffers[2];
+};
+
+static struct i2s_nrfx i2s_nrfx;
+
+static void
+nrfx_add_buffer(struct i2s *i2s, struct i2s_sample_buffer *buffer)
+{
+ nrfx_i2s_buffers_t nrfx_buffers = {0};
+ nrfx_err_t err;
+
+ assert(i2s != NULL);
+ if (buffer == NULL) {
+ return;
+ }
+
+ if (i2s->direction == I2S_OUT || i2s->direction == I2S_OUT_IN) {
+ nrfx_buffers.p_tx_buffer = buffer->sample_data;
+ }
+ if (i2s->direction == I2S_IN || i2s->direction == I2S_OUT_IN) {
+ nrfx_buffers.p_rx_buffer = buffer->sample_data;
+ }
+
+ assert(i2s_nrfx.nrfx_queued_count < 2);
+ assert(i2s_nrfx.nrfx_buffers[i2s_nrfx.nrfx_queued_count] == NULL);
+
+ i2s_nrfx.nrfx_buffers[i2s_nrfx.nrfx_queued_count] = buffer;
+ i2s_nrfx.nrfx_queued_count++;
+ if (i2s_nrfx.nrfx_queued_count == 1) {
+ i2s_driver_state_changed (i2s, I2S_STATE_RUNNING);
+ err = nrfx_i2s_start(&nrfx_buffers, buffer->sample_count * i2s->sample_size_in_bytes / 4, 0);
+ } else {
+ err = nrfx_i2s_next_buffers_set(&nrfx_buffers);
+ }
+
+ assert(err == NRFX_SUCCESS);
+}
+
+static void
+feed_nrfx(void)
+{
+ struct i2s_sample_buffer *buffer;
+
+ buffer = i2s_driver_buffer_get(i2s_nrfx.i2s);
+ nrfx_add_buffer(i2s_nrfx.i2s, buffer);
+}
+
+static void
+i2s_nrfx_data_handler(const nrfx_i2s_buffers_t *p_released, uint32_t status)
+{
+ struct i2s_sample_buffer *buffer;
+
+ TP_ON(5);
+ TP_OFF(5);
+ if (p_released != NULL &&
+ (p_released->p_rx_buffer != NULL || p_released->p_tx_buffer != NULL)) {
+ i2s_nrfx.nrfx_queued_count--;
+ assert(i2s_nrfx.nrfx_queued_count >= 0);
+ buffer = i2s_nrfx.nrfx_buffers[0];
+ assert(buffer->sample_data == p_released->p_tx_buffer || buffer->sample_data == p_released->p_rx_buffer);
+ i2s_nrfx.nrfx_buffers[0] = i2s_nrfx.nrfx_buffers[1];
+ i2s_nrfx.nrfx_buffers[1] = NULL;
+ i2s_driver_buffer_put(i2s_nrfx.i2s, buffer);
+ }
+ if (i2s_nrfx.running && i2s_nrfx.nrfx_queued_count < 2) {
+ assert(i2s_nrfx.nrfx_buffers[1] == NULL);
+ feed_nrfx();
+ }
+ if (status == NRFX_I2S_STATUS_TRANSFER_STOPPED) {
+ i2s_driver_state_changed(i2s_nrfx.i2s, I2S_STATE_STOPPED);
+ }
+}
+
+static int
+i2s_nrfx_init(struct i2s *i2s, const struct i2s_cfg *cfg)
+{
+ int rc;
+
+ i2s_nrfx.i2s = i2s;
+
+ NVIC_SetVector(nrfx_get_irq_number(NRF_I2S), (uint32_t)nrfx_i2s_irq_handler);
+
+ i2s_nrfx.nrfx_i2s_cfg = cfg->nrfx_i2s_cfg;
+ switch (cfg->nrfx_i2s_cfg.sample_width) {
+ case NRF_I2S_SWIDTH_8BIT:
+#if defined(I2S_CONFIG_SWIDTH_SWIDTH_8BitIn16)
+ case NRF_I2S_SWIDTH_8BIT_IN16BIT:
+#endif
+#if defined(I2S_CONFIG_SWIDTH_SWIDTH_8BitIn32)
+ case NRF_I2S_SWIDTH_8BIT_IN32BIT:
+#endif
+ i2s->sample_size_in_bytes = 1;
+ break;
+ case NRF_I2S_SWIDTH_16BIT:
+#if defined(I2S_CONFIG_SWIDTH_SWIDTH_16BitIn32)
+ case NRF_I2S_SWIDTH_16BIT_IN32BIT:
+#endif
+ i2s->sample_size_in_bytes = 2;
+ break;
+ case NRF_I2S_SWIDTH_24BIT:
+#if defined(I2S_CONFIG_SWIDTH_SWIDTH_24BitIn32)
+ case NRF_I2S_SWIDTH_24BIT_IN32BIT:
+#endif
+#if defined(I2S_CONFIG_SWIDTH_SWIDTH_32Bit)
+ case NRF_I2S_SWIDTH_32BIT:
+#endif
+ i2s->sample_size_in_bytes = 4;
+ break;
+ }
+
+ i2s->direction = I2S_INVALID;
+ if (cfg->nrfx_i2s_cfg.sdin_pin != NRFX_I2S_PIN_NOT_USED) {
+ i2s->direction = I2S_IN;
+ }
+ if (cfg->nrfx_i2s_cfg.sdout_pin != NRFX_I2S_PIN_NOT_USED) {
+ i2s->direction |= I2S_OUT;
+ }
+
+ rc = i2s_init(i2s, cfg->pool);
+
+ if (rc != OS_OK) {
+ nrfx_i2s_uninit();
+ goto end;
+ }
+
+ i2s->sample_rate = cfg->sample_rate;
+ i2s->driver_data = &i2s_nrfx;
+end:
+ return rc;
+}
+
+int
+i2s_create(struct i2s *i2s, const char *name, const struct i2s_cfg *cfg)
+{
+ return os_dev_create(&i2s->dev, name, OS_DEV_INIT_PRIMARY,
+ 100, (os_dev_init_func_t)i2s_nrfx_init, (void *)cfg);
+}
+
+int
+i2s_driver_stop(struct i2s *i2s)
+{
+ struct i2s_sample_buffer *buffer;
+
+ i2s_nrfx.running = false;
+ nrfx_i2s_stop();
+
+ assert(i2s_nrfx.i2s->state == I2S_STATE_STOPPED);
+
+ while (NULL != (buffer = i2s_driver_buffer_get(i2s))) {
Review comment:
Ugly comparison! :-P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591#issuecomment-838122205
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591#issuecomment-840407690
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2591: hw/drivers/i2s: Add I2S driver for NRF5x families
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2591:
URL: https://github.com/apache/mynewt-core/pull/2591#issuecomment-838122205
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org