You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/28 00:23:00 UTC
[GitHub] [skywalking] heyanlong opened a new pull request #4582: Add 200000
microsecond sleep in E2E-PHP
heyanlong opened a new pull request #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4582: Add 200000
microsecond sleep in E2E-PHP
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] heyanlong commented on issue #4582: Add 200000
microsecond sleep in E2E-PHP
Posted by GitBox <gi...@apache.org>.
heyanlong commented on issue #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582#issuecomment-605373218
> why sleep so long unnecessarily? This will slow down the checks drastically
simulation 200ms processing time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4582: Add 200000
microsecond sleep in E2E-PHP
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582#issuecomment-605374414
@kezhenxu94 I think the title is microsecond, not ms, which usually is meaning millionseconds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4582: Add 200000
microsecond sleep in E2E-PHP
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582#issuecomment-605370300
why sleep so long unnecessarily? This will slow down the checks drastically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4582: Add 200000
microsecond sleep in E2E-PHP
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582#issuecomment-605373753
> > why sleep so long unnecessarily? This will slow down the checks drastically
>
>
> simulation 200ms processing time
Your title is misleading, which says sleep 200000ms=200s=~2minutes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4582: Add 200000
microsecond sleep in E2E-PHP
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4582: Add 200000 microsecond sleep in E2E-PHP
URL: https://github.com/apache/skywalking/pull/4582#issuecomment-605373753
> > why sleep so long unnecessarily? This will slow down the checks drastically
>
>
> simulation 200ms processing time
Your title is misleading, which says 200000ms=200s=~2minutes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services