You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/05/12 08:54:47 UTC
Review Request 34079: SENTRY-727: Update jdo model for grant user to
role
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
Repository: sentry
Description
-------
Update jdo model for grant user to role
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 0076753
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java d7937d0
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 35319db
Diff: https://reviews.apache.org/r/34079/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review126520
-----------------------------------------------------------
Thank Colin for your contribution, I left some comments.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1117)
<https://reviews.apache.org/r/34079/#comment189540>
We don't need the change here. Seems if group is null, we still need to call the jdo query, how about update code to reduce creating unused role set.
````
Set<String> roles = null;
if (group is not null) {
execute query..
} else {
roles = Sets.newHashSet()
}
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1293)
<https://reviews.apache.org/r/34079/#comment189544>
yes, we should check `users != null` before `openTransaction()`
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1397)
<https://reviews.apache.org/r/34079/#comment189549>
Should check if group or user is null or empty here.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1835)
<https://reviews.apache.org/r/34079/#comment189552>
`getMSentryPrivileges` called `openTransaction()`, it is better to share a pm at one method call.
- Dapeng Sun
On 五月 12, 2015, 2:54 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated 五月 12, 2015, 2:54 p.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 0076753
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java d7937d0
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 35319db
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
> On 四月 1, 2016, 2:03 a.m., Jerry Chen wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, line 1325
> > <https://reviews.apache.org/r/34079/diff/1/?file=956186#file956186line1325>
> >
> > Shall we move the line "result = convertToTSentryRoles(mSentryRoles);" to the of after comitTransaction(pm)?
Hi Jerry, we may can't move it, the convertToTSentryRole() called `MSentryRole#getGroups()` which is lazy-loading, it should be call before transaction. committed.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review126284
-----------------------------------------------------------
On 四月 8, 2016, 3:13 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated 四月 8, 2016, 3:13 a.m.)
>
>
> Review request for sentry, Dapeng Sun and Jerry Chen.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review126284
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo (line 48)
<https://reviews.apache.org/r/34079/#comment189225>
Do we need to remove the trailing spaces in the added code?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1263)
<https://reviews.apache.org/r/34079/#comment189230>
Can the groups != null check put just after:
Set<String> result = new HashSet<String>();
And if null, then return the empty result.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1293)
<https://reviews.apache.org/r/34079/#comment189232>
Can the users != null check put the after:
Set<String> result = new HashSet<String>();
and if null then return the result.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1313)
<https://reviews.apache.org/r/34079/#comment189233>
The parameters has both groups and users,
But the method name read getTSentryRolesForUser,
Needs to check whether this is the true intend.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1323)
<https://reviews.apache.org/r/34079/#comment189234>
Shall we move the line "result = convertToTSentryRoles(mSentryRoles);" to the of after comitTransaction(pm)?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1339)
<https://reviews.apache.org/r/34079/#comment189235>
Move the check of groups != null to the beginning and return early.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1356)
<https://reviews.apache.org/r/34079/#comment189236>
Move the check of users != null to the beginning and return early.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1398)
<https://reviews.apache.org/r/34079/#comment189237>
Check: Do the two calls getRoleNamesForGroups and getRoleNamesForUsers need to be in the same transaction?
- Jerry Chen
On May 12, 2015, 6:54 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 6:54 a.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 0076753
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java d7937d0
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 35319db
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review127737
-----------------------------------------------------------
Ship it!
Ship It!
- Jerry Chen
On April 8, 2016, 3:13 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 3:13 a.m.)
>
>
> Review request for sentry, Dapeng Sun and Jerry Chen.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/
-----------------------------------------------------------
(Updated 四月 8, 2016, 9:24 a.m.)
Review request for sentry, Dapeng Sun and Jerry Chen.
Repository: sentry
Description
-------
Update jdo model for grant user to role
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/
-----------------------------------------------------------
(Updated 四月 8, 2016, 3:13 a.m.)
Review request for sentry, Dapeng Sun and Jerry Chen.
Repository: sentry
Description
-------
Update jdo model for grant user to role
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
> On 四月 7, 2016, 3:44 a.m., Jerry Chen wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java, line 1497
> > <https://reviews.apache.org/r/34079/diff/3/?file=1327638#file1327638line1497>
> >
> > Suggest to pass null instead of Sets.newHashSet(""). The same to next 3 instances.
Hi Jerry. Thank you for catching it, here should be the user set of requestor. I fixed it.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review127543
-----------------------------------------------------------
On 四月 8, 2016, 3:13 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated 四月 8, 2016, 3:13 a.m.)
>
>
> Review request for sentry, Dapeng Sun and Jerry Chen.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review127543
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1381)
<https://reviews.apache.org/r/34079/#comment190890>
Suggest to early return for groups == null.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1398)
<https://reviews.apache.org/r/34079/#comment190891>
Suggest to early return for users == null.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1438)
<https://reviews.apache.org/r/34079/#comment190893>
It would better put getRoleNamesForGroups and getRoleNamesForUsers in the same persistent manager transcation.
So we need to refactor getRoleNamesForGroups and getRoleNamesForUsers accepting a shared PersistenceManager similar to getRolesForUsers.
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java (line 1480)
<https://reviews.apache.org/r/34079/#comment190894>
Suggest to pass null instead of Sets.newHashSet(""). The same to next 3 instances.
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java (line 2016)
<https://reviews.apache.org/r/34079/#comment190895>
Suggest to pass null instead of new HashSet<String>(). The same for the next instance.
- Jerry Chen
On April 6, 2016, 2:46 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 2:46 p.m.)
>
>
> Review request for sentry, Dapeng Sun and Jerry Chen.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/
-----------------------------------------------------------
(Updated 四月 6, 2016, 2:46 p.m.)
Review request for sentry, Dapeng Sun and Jerry Chen.
Repository: sentry
Description
-------
Update jdo model for grant user to role
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Ma JUNJIE <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/#review127320
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 58)
<https://reviews.apache.org/r/34079/#comment190585>
it's better not using * in import.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 880)
<https://reviews.apache.org/r/34079/#comment190587>
For the user name, should it be case insensitive like role name? if yes, related test cases should be added.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 911)
<https://reviews.apache.org/r/34079/#comment190588>
The following code is duplicated many times, it's better to be wrapped in a method.
Query query = pm.newQuery(MSentryUser.class);
query.setFilter("this.userName == t");
query.declareParameters("java.lang.String t");
query.setUnique(true);
- Ma JUNJIE
On April 6, 2016, 5:14 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34079/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:14 a.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update jdo model for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
>
> Diff: https://reviews.apache.org/r/34079/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 34079: SENTRY-727: Update jdo model for grant user
to role
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34079/
-----------------------------------------------------------
(Updated 四月 6, 2016, 5:14 a.m.)
Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
Changes
-------
Updated patch according comments
Repository: sentry
Description
-------
Update jdo model for grant user to role
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 24514ea
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo d8f69b5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java dbb5d8e
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 02f98e2
Diff: https://reviews.apache.org/r/34079/diff/
Testing
-------
Thanks,
Colin Ma