You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 21:34:10 UTC

[GitHub] [airflow] dlampa opened a new pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

dlampa opened a new pull request #17298:
URL: https://github.com/apache/airflow/pull/17298


   closes: #16013   
   
   This is a workaround for the issue with `kubernetes-client` that results in an invalid API request by `V1LabelSelector` and `match_expressions`. This employs an alternative approach that matches the desired functionality by specifying the `label_selector` as a comma separated string of labels that the pod should have in order for it to be returned by `list_namespaced_pod`.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dlampa commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
dlampa commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-889328576


   @XD-DENG Thank you :) Rebasing done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-889431421


   @dlampa , Congrats on your first PR merged in Airflow project ;-)
   
   Really appreciate your help fixing this issue, and thanks for your interest contributing to Airflow. Look forward to seeing you again in other Issue discussions or PRs!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-889430312


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-888636745


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG merged pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #17298:
URL: https://github.com/apache/airflow/pull/17298


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-889094268


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-889430633


   Merged. One test was failing but irrelevant to me and should be a flaky test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dlampa commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
dlampa commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-889456928


   @XD-DENG Thank you, definitely looking forward to contributing more to this amazing project in the future!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dlampa commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

Posted by GitBox <gi...@apache.org>.
dlampa commented on pull request #17298:
URL: https://github.com/apache/airflow/pull/17298#issuecomment-888640913


   In addition to running the complete battery of tests, this was also tested in the breeze KinD cluster by disabling the deletion of worker pods (i.e. `AIRFLOW__KUBERNETES__DELETE_WORKER_PODS` to False in Scheduler `env`), and letting the `airflow-cleanup` cronjob (as defined in the official helm chart) spin off individual cleanup pods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org