You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/11/13 17:27:14 UTC
[GitHub] zeppelin pull request #1625: [ZEPPELIN-1657] Private/public mode for user no...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1625
[ZEPPELIN-1657] Private/public mode for user note creation/import
### What is this PR for?
In multi-user environment when users create a notebook normally they would expect that notebook be listed only in their list/workbench. Currently Zeppelin creates/imports notes as public by default. There should be at least a way to pass through configuration to make this behaviour private be default. Should discuss whether it's public or private by default.
### What type of PR is it?
Improvement
### Todos
* [x] - set permissions on create/import
* [x] - test
* [ ] - review, feedback, decide whether public/private by default
* [ ] - pass through `zeppelin-env.sh` as well?
### What is the Jira issue?
[ZEPPELIN-1657](https://issues.apache.org/jira/browse/ZEPPELIN-1657)
### How should this be tested?
1. set `zeppelin.notebook.public` property as false in `zeppelin-site.xml`
2. login as user1 and create noteA, note should appear in your list of notes
3. logout and login as user2, shouldn't be able to see noteA
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? maybe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/public-note-create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit 09b23e150c3014b93def4039a63ba61fd4ee0d3b
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T09:13:18Z
add property to site.xml
commit 0c691b23f76d9c62f1230437510779fdacfa5253
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T10:03:54Z
add var to env.sh
commit 610ada94eba51efba5b6f607895f779e3f207027
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T10:52:23Z
add variable to ZeppelinConfiguration
commit bebe6be809cd6566e3de334c9b9d5585bb5596ae
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T13:15:13Z
set new note permissions
commit cf2acb0e11d253f894e6d78f3dda2bb1f20e4db7
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T13:15:51Z
set permissions on note create and import
commit c7faeee18836c99758e1eb214843844074dda301
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T16:57:51Z
read env var from conf file directly
commit fb44fd7af06558a88356544131fc9c8f10696330
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T16:58:04Z
add test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1625: [ZEPPELIN-1657] Private/public mode for user no...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1625
[ZEPPELIN-1657] Private/public mode for user note creation/import
### What is this PR for?
In multi-user environment when users create a notebook normally they would expect that notebook be listed only in their list/workbench. Currently Zeppelin creates/imports notes as public by default. There should be at least a way to pass through configuration to make this behaviour private be default. Should discuss whether it's public or private by default.
### What type of PR is it?
Improvement
### Todos
* [x] - set permissions on create/import
* [x] - test
* [x] - review, feedback, decide whether public/private by default
* [x] - pass through env. config
### What is the Jira issue?
[ZEPPELIN-1657](https://issues.apache.org/jira/browse/ZEPPELIN-1657)
### How should this be tested?
1. set `zeppelin.notebook.public` property as false in `zeppelin-site.xml`
2. login as user1 and create noteA, note should appear in your list of notes
3. logout and login as user2, shouldn't be able to see noteA
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? maybe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/public-note-create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit b7f28b30616419d22b62d116f70568821c6f3711
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T09:13:18Z
add property to site.xml
commit 4062af09c9a585f7a9dd164bf3d8b90ceb3bde75
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T10:03:54Z
add var to env.sh
commit 97324096f674d61dee732561d986db728985d2fa
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T10:52:23Z
add variable to ZeppelinConfiguration
commit 44297a40fd67ce3fe25756417091e4fa6ccf9176
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T13:15:13Z
set new note permissions
commit 28abffac6a4f6fd8514fdea706af12a42958406e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T13:15:51Z
set permissions on note create and import
commit 496b80c0823494d9c532574bcd69538b8bb2a3d8
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T16:57:51Z
read env var from conf file directly
commit 1a945e8e183ec1baab807b5c9ce522274093b061
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T16:58:04Z
add test
commit 876b79880ad0426f691e390c5e8b25baef35b380
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-14T03:39:40Z
fix vfs testSave npe
commit f862ae1e875d51c18c353b9eda9cd2d0734f5a12
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-14T04:30:01Z
fix InterpreterFactory test
commit fc91b2f15725e91db1cbdf0439e8dd8779fc4f68
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-16T08:14:44Z
add description to install config
commit 010c26200d274620eea65a414f58dad8bbaa47f0
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-17T05:53:10Z
fix test: set state back
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
CI is green and ready for review. @Leemoonsoo feedback would be appreciated, especially regarding the naming of say `zeppelin.notebook.public` and `isPublic`. another way would be to name them as private, e.g. `zeppelin.notebook.public` and `isPrivate` with opposite values. let me know what you think in general
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1625: [ZEPPELIN-1657] Private/public mode for user no...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@Leemoonsoo CI is finally green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@khalidhuseynov Can you make CI green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1625: [ZEPPELIN-1657] Private/public mode for user no...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1625
[ZEPPELIN-1657] Private/public mode for user note creation/import
### What is this PR for?
In multi-user environment when users create a notebook normally they would expect that notebook be listed only in their list/workbench. Currently Zeppelin creates/imports notes as public by default. There should be at least a way to pass through configuration to make this behaviour private be default. Should discuss whether it's public or private by default.
### What type of PR is it?
Improvement
### Todos
* [x] - set permissions on create/import
* [x] - test
* [x] - review, feedback, decide whether public/private by default
* [x] - pass through env. config
### What is the Jira issue?
[ZEPPELIN-1657](https://issues.apache.org/jira/browse/ZEPPELIN-1657)
### How should this be tested?
1. set `zeppelin.notebook.public` property as false in `zeppelin-site.xml`
2. login as user1 and create noteA, note should appear in your list of notes
3. logout and login as user2, shouldn't be able to see noteA
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? maybe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/public-note-create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit b7f28b30616419d22b62d116f70568821c6f3711
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T09:13:18Z
add property to site.xml
commit 4062af09c9a585f7a9dd164bf3d8b90ceb3bde75
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T10:03:54Z
add var to env.sh
commit 97324096f674d61dee732561d986db728985d2fa
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-11T10:52:23Z
add variable to ZeppelinConfiguration
commit 44297a40fd67ce3fe25756417091e4fa6ccf9176
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T13:15:13Z
set new note permissions
commit 28abffac6a4f6fd8514fdea706af12a42958406e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T13:15:51Z
set permissions on note create and import
commit 496b80c0823494d9c532574bcd69538b8bb2a3d8
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T16:57:51Z
read env var from conf file directly
commit 1a945e8e183ec1baab807b5c9ce522274093b061
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-13T16:58:04Z
add test
commit 876b79880ad0426f691e390c5e8b25baef35b380
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-14T03:39:40Z
fix vfs testSave npe
commit f862ae1e875d51c18c353b9eda9cd2d0734f5a12
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-14T04:30:01Z
fix InterpreterFactory test
commit fc91b2f15725e91db1cbdf0439e8dd8779fc4f68
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-16T08:14:44Z
add description to install config
commit f2a4fe6d884540f318947289f83f98390f2af227
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-11-17T05:53:10Z
fix test: set state back
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@Leemoonsoo fixed the test failure coming from rebase. all profiles pass except the last selenium test failure with:
```
Results :
Tests in error:
ParagraphActionsIT.testEditOnDoubleClick:443 � ElementNotVisible Element is no...
Tests run: 17, Failures: 0, Errors: 1, Skipped: 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1625: [ZEPPELIN-1657] Private/public mode for user no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1625
Thanks @khalidhuseynov for the contribution.
I think make permission public by default make sense, while it is current behavior.
Could you add new configuration to `docs/install/install.md#apache-zeppelin-configuration`, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1625: [ZEPPELIN-1657] Private/public mode for user no...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@Leemoonsoo thanks for review, addressed comments in fc91b2f15725e91db1cbdf0439e8dd8779fc4f68. also rebased and resolved conflicts since `docs/install/install.md` was recently changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1625: [ZEPPELIN-1657] Private/public mode for user note crea...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1625
Thank you for the contribution!
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---