[GitHub] [nifi] greyp9 commented on a diff in pull request #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…

["greyp9 (via GitHub)" <gi...@apache.org>]

greyp9 commented on code in PR #7379:
URL: https://github.com/apache/nifi/pull/7379#discussion_r1230077060


##########
nifi-manifest/nifi-runtime-manifest-test/src/test/java/org/apache/nifi/runtime/manifest/TestRuntimeManifest.java:
##########
@@ -264,6 +265,7 @@ void testRuntimeManifest() throws IOException {
         assertNotNull(routeOnAttributeDef.getDynamicRelationship().getDescription());
 
         assertTrue(routeOnAttributeDef.getSupportsDynamicProperties());
+        assertTrue(routeOnAttributeDef.getSupportsSensitiveDynamicProperties());

Review Comment:
   > Seems like this one is causing a test failure because RouteOnAttribute doesn't support sensitive dynamic properties. Probably have to locate a different definition for a component we know supports it, since all the ones currently in the test don't (I think).
   > 
   > ```
   > [ERROR] Failures:
   > [ERROR]   TestRuntimeManifest.testRuntimeManifest:268 expected: <true> but was: <false>
   > ```
   
   Yep, my bad.  Looks like ExecuteSQL has the annotation; added an assertion for that one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org