You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/12 16:06:25 UTC

[GitHub] [incubator-devlake] likyh opened a new pull request, #3406: fix: display curl in the webhook page

likyh opened a new pull request, #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406

   # Summary
   
   display curl in the webhook page
   
   ![kBKVYCqVbG](https://user-images.githubusercontent.com/3294100/195393165-b0966b00-4ce9-48aa-b2b0-8043d848b3fa.jpg)
   
   The text copied is:
   ```
   curl http://localhost:4000/api/plugins/webhook/1/deployments -X 'POST' -d "{
     \"repo_url\":\"$CIRCLE_REPOSITORY_URL\",
     \"commit_sha\":\"$CIRCLE_SHA1\",
     \"start_time\":\"$start_time\"
   }"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] Startrekzky merged pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
Startrekzky merged PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mintsweet commented on pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#issuecomment-1276951658

   @likyh The style of the url display is broken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mintsweet commented on pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#issuecomment-1277083835

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh commented on pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
likyh commented on PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#issuecomment-1277287901

   ![image](https://user-images.githubusercontent.com/3294100/195554912-431f784b-b438-4aa2-9b98-eb64ed448036.png)
   fix some wording again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
mintsweet commented on code in PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#discussion_r994373830


##########
config-ui/src/pages/connections/incoming-webhook/styled.js:
##########
@@ -143,10 +143,14 @@ export const FormWrapper = styled.div`
       display: flex;
       align-items: center;
       justify-content: space-between;
-      padding: 0 10px;
-      height: 38px;
+      padding: 10px;
+      height: auto;

Review Comment:
   This property can not be set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh commented on pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
likyh commented on PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#issuecomment-1276959466

   ![bDH3P7rcDM](https://user-images.githubusercontent.com/3294100/195487846-88bb49d8-a32c-4e1c-8b1a-e8aefd5e9c99.jpg)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#discussion_r994375922


##########
config-ui/src/pages/connections/incoming-webhook/styled.js:
##########
@@ -143,10 +143,14 @@ export const FormWrapper = styled.div`
       display: flex;
       align-items: center;
       justify-content: space-between;
-      padding: 0 10px;
-      height: 38px;
+      padding: 10px;
+      height: auto;

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mintsweet commented on pull request #3406: fix: display curl in the webhook page

Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3406:
URL: https://github.com/apache/incubator-devlake/pull/3406#issuecomment-1277293198

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org