You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by QiangCai <gi...@git.apache.org> on 2016/12/07 13:36:58 UTC
[GitHub] incubator-carbondata pull request #411: [WIP]Support date char
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/411
[WIP]Support date char
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/incubator-carbondata support_date_char
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #411
----
commit b16e20f70c6552fc49a3ae9c3b62944d555aa929
Author: QiangCai <qi...@qq.com>
Date: 2016-12-07T06:29:29Z
support date/char
commit ae72fca4188fcd449529650e378f06e00c115853
Author: QiangCai <qi...@qq.com>
Date: 2016-12-07T10:55:48Z
support datatype: date and char
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #411: [CARBONDATA-535]Support data type: d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #411: [WIP]Support data type: date and cha...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/411#discussion_r91829442
--- Diff: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/directdictionary/TimestampDataTypeDirectDictionaryTestCase.scala ---
@@ -69,86 +76,134 @@ class TimestampDataTypeDirectDictionaryTest extends QueryTest with BeforeAndAfte
val csvFilePath = currentDirectory + "/src/test/resources/datasample.csv"
sql("LOAD DATA local inpath '" + csvFilePath + "' INTO TABLE directDictionaryTable OPTIONS" +
"('DELIMITER'= ',', 'QUOTECHAR'= '\"')");
+// sql("select * from directDictionaryTable").show
+ sql("LOAD DATA local inpath '" + csvFilePath + "' INTO TABLE directDictionaryTable_date OPTIONS" +
+ "('DELIMITER'= ',', 'QUOTECHAR'= '\"')");
+ sql("select * from directDictionaryTable_date").show
sql("LOAD DATA local inpath '" + csvFilePath + "' INTO TABLE directDictionaryTable_hive");
+
} catch {
case x: Throwable => CarbonProperties.getInstance()
.addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "dd-MM-yyyy")
}
}
test("test direct dictionary for not null condition") {
+// checkAnswer(
--- End diff --
remove commented code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #411: [WIP]Support data type: date and cha...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/411#discussion_r91828573
--- Diff: examples/spark2/src/main/resources/data.csv ---
@@ -1,10 +1,10 @@
-1,10,100,48.4,spark,2015/4/23,1.23
-5,17,140,43.4,spark,2015/7/27,3.45
-1,11,100,44.4,flink,2015/5/23,23.23
-1,10,150,43.4,spark,2015/7/24,254.12
-1,10,100,47.4,spark,2015/7/23,876.14
-3,14,160,43.4,hive,2015/7/26,3454.32
-2,10,100,43.4,impala,2015/7/23,456.98
-1,10,100,43.4,spark,2015/5/23,32.53
-4,16,130,42.4,impala,2015/7/23,67.23
-1,10,100,43.4,spark,2015/7/23,832.23
\ No newline at end of file
+1,10,100,48.4,spark,2015/4/23,1.23,2015/4/23,aaa
--- End diff --
can you add hour, minute and second for timestampField?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #411: [WIP]Support data type: date and cha...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/411#discussion_r91828568
--- Diff: core/src/test/java/org/apache/carbondata/scan/collector/impl/DictionaryBasedResultCollectorTest.java ---
@@ -162,7 +162,7 @@
new MockUp<DirectDictionaryKeyGeneratorFactory>() {
@SuppressWarnings("unused") @Mock DirectDictionaryGenerator getDirectDictionaryGenerator(
DataType dataType) {
- if (dataType == DataType.TIMESTAMP) return new TimeStampDirectDictionaryGenerator(
+ if (dataType == DataType.TIMESTAMP || dataType == DataType.DATE) return new TimeStampDirectDictionaryGenerator(
--- End diff --
please add `{`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #411: [WIP]Support data type: date and char
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/411
Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/125/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #411: [WIP]Support data type: date and cha...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/411#discussion_r91828592
--- Diff: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/directdictionary/TimestampDataTypeDirectDictionaryTestCase.scala ---
@@ -57,7 +56,15 @@ class TimestampDataTypeDirectDictionaryTest extends QueryTest with BeforeAndAfte
)
sql(
- "CREATE TABLE if not exists directDictionaryTable_hive (empno int,doj Timestamp, " +
+ "CREATE TABLE if not exists directDictionaryTable_date (empno int,doj date, " +
+ "salary int) " +
+ "STORED BY 'org.apache.carbondata.format'"
+ )
+
+ sql("desc formatted directDictionaryTable_date").show(false)
--- End diff --
remove this, it requires manually check, not suitable for test case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #411: [WIP]Support data type: date and char
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/411
Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/180/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #411: [WIP]Support data type: date and char
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/411
@ravipesala
Please correct CI to support -Pbuild-with-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #411: [WIP]Support data type: date and char
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/411
Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/68/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #411: [WIP]Support data type: date and char
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/411
Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/123/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---