You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/04/07 00:55:41 UTC

[kudu-CR] cfile: clean up encoding-test to use fewer templates

Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 )

Change subject: cfile: clean up encoding-test to use fewer templates
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15044/1/src/kudu/cfile/type_encodings.h
File src/kudu/cfile/type_encodings.h:

http://gerrit.cloudera.org:8080/#/c/15044/1/src/kudu/cfile/type_encodings.h@46
PS1, Line 46: 
> nit: while you are here, maybe stick * and & to the type in the changes lin
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a
Gerrit-Change-Number: 15044
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 07 Apr 2020 00:55:41 +0000
Gerrit-HasComments: Yes