[GitHub] [incubator-hugegraph-computer] javeme commented on a diff in pull request #245: Change etcd url only for ci

["javeme (via GitHub)" <gi...@apache.org>]

javeme commented on code in PR #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245#discussion_r1204252411


##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/integrate/IntegrateTestSuite.java:
##########
@@ -45,10 +46,13 @@ public static void setup() {
         OptionSpace.register("computer",
                              "org.apache.hugegraph.computer.core.config." +
                              "ComputerOptions");
-        OptionSpace.register("computer-rpc",
-                             "org.apache.hugegraph.config.RpcOptions");
+        OptionSpace.register("computer-rpc", "org.apache.hugegraph.config.RpcOptions");

Review Comment:
   also update ComputerOptions



##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/unit/UnitTestBase.java:
##########
@@ -73,15 +75,26 @@ protected static void clearAll() {
         client().graphs().clearGraph(GRAPH, "I'm sure to delete all data");
     }
 
+    @AfterClass
+    public static void cleanup() {

Review Comment:
   move to line 150 to keep the customary order



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org