You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/17 02:01:25 UTC
[GitHub] [airflow] kaxil opened a new pull request #8413: Add 1.10.10
SecretsBackends contrib paths with Deprecation Warning
kaxil opened a new pull request #8413: Add 1.10.10 SecretsBackends contrib paths with Deprecation Warning
URL: https://github.com/apache/airflow/pull/8413
Add 1.10.10 SecretsBackends contrib paths with Deprecation Warning
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #8413: Add
back-compat modules from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413#discussion_r410179769
##########
File path: airflow/contrib/secrets/__init__.py
##########
@@ -0,0 +1,26 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""This package is deprecated. Please use `airflow.secrets` or `airflow.providers.*.secrets`."""
+
+import warnings
+
+warnings.warn(
+ "This package is deprecated. Please use `airflow.secrets` or `airflow.providers.*.secrets`.",
+ DeprecationWarning,
+ stacklevel=2,
+)
Review comment:
```suggestion
```
I would probably say no deprecation is needed here -- this will issue two deprecations as a result, cos importing any package under this will have to import this too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8413: Add back-compat modules
from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413#issuecomment-615219456
> But there were never any contrib secrets?
Not in Master, yes but in Airflow 1.10.10 as we don't have "Providers" folder for v1-10-* series:
https://github.com/apache/airflow/tree/v1-10-test/airflow/contrib/secrets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] BasPH edited a comment on issue #8413: Add back-compat
modules from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
BasPH edited a comment on issue #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413#issuecomment-615218599
~But there were never any contrib secrets?~ Nevermind, they exist in 1.10.10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #8413: Add back-compat modules
from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #8413: Add back-compat
modules from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413#issuecomment-615219456
> But there were never any contrib secrets?
Not in Master, yes but in Airflow 1.10.10 as we don't have "Providers" folder for v1-10-* series:
https://github.com/apache/airflow/tree/v1-10-test/airflow/contrib/secrets
And we don't want to have the "Providers" folder in 1.10.* as it might fail implicit namepackages from getting discovered for our Backport Packages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8413: Add back-compat modules
from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413#issuecomment-615211180
> Why do we need these? They never existed in thest
Otherwise "contrib" Secrets won't work for people upgrading to Airflow 2.0 (when that happens)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] BasPH commented on issue #8413: Add back-compat modules
from 1.10.10 for SecretsBackends
Posted by GitBox <gi...@apache.org>.
BasPH commented on issue #8413: Add back-compat modules from 1.10.10 for SecretsBackends
URL: https://github.com/apache/airflow/pull/8413#issuecomment-615218599
But there were never any contrib secrets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services