You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/07/29 17:04:00 UTC
[jira] [Commented] (SOLR-13657) Fix
TestXPathRecordReader.testUnsupported_Xpaths
[ https://issues.apache.org/jira/browse/SOLR-13657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895452#comment-16895452 ]
ASF subversion and git services commented on SOLR-13657:
--------------------------------------------------------
Commit 1d303cee7f533fa8edb3477bf14fbc5f5bf3d563 in lucene-solr's branch refs/heads/master from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1d303ce ]
SOLR-13657: fix unsupported xpath test in TestXPathRecordReader
* use expectThrows to verify the exception and the message
* fix NPE in the test
> Fix TestXPathRecordReader.testUnsupported_Xpaths
> ------------------------------------------------
>
> Key: SOLR-13657
> URL: https://issues.apache.org/jira/browse/SOLR-13657
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Munendra S N
> Assignee: Munendra S N
> Priority: Minor
>
> {{tTestXPathRecordReader.testUnsupported_Xpaths}} covers some negative cases for xpath
> While working on SOLR-12555, found that, here NPE thrown as rr is never set not the expected exception
> {code:java}
> try {
> rr.addField("bold" ,"b", false);
> fail("A RuntimeException was expected: 'b' xpaths must begin with '/'.");
> }
> catch (RuntimeException ex) { }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org