You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/03 04:21:29 UTC

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #2960: sigdeliver: fix system block when kill signal to idle in SMP

GUIDINGLI opened a new pull request #2960:
URL: https://github.com/apache/incubator-nuttx/pull/2960


   ## Summary
   sigdeliver: fix system block when kill signal to idle in SMP
   
       Bug description:
       
       CONFIG_SMP=y
       
       Suppose we have 2 cores in SMP, here is the ps return:
       
       PID GROUP CPU PRI POLICY TYPE    NPX STATE     STACK   USED  FILLED COMMAND
         0     0   0   0 FIFO   Kthread N-- Assigned 004076 000748  18.3%  CPU0 IDLE
         1     0   1   0 FIFO   Kthread N-- Running  004096 000540  13.1%  CPU1 IDLE
       
       nsh> kill -4 0
       or:
       nsh> kill -4 1
       
       system blocked.
       
       Reason:
       
       In func xx_sigdeliver() restore stage, when saved_irqcount == 0, that means
       rtcb NOT in critical_section before switch to xx_sigdeliver(), then we need
       reset the critical_section state before swith back.
       
       Fix:
       
       Add condition to cover saved_irqcount == 0.
   
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2960: sigdeliver: fix system block when kill signal to idle in SMP

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2960:
URL: https://github.com/apache/incubator-nuttx/pull/2960


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2960: sigdeliver: fix system block when kill signal to idle in SMP

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2960:
URL: https://github.com/apache/incubator-nuttx/pull/2960#issuecomment-789517270


   @GUIDINGLI 
   
   I can reproduce the bug with sabre6quad:smp and confirmed that this PR fixes the problem.
   Could you please apply the same logic to armv6-m/arm_sigdeliver.c and amend the commit?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org