You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/09/11 23:51:28 UTC
Review Request 38321: Adding upgrade specifications to docs for
'.json' endpoints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38321/
-----------------------------------------------------------
Review request for mesos and Adam B.
Repository: mesos
Description
-------
Adding a Note for the deprecation of endpoints with '.json' extension.
Diffs
-----
docs/upgrades.md c4b2880
Diff: https://reviews.apache.org/r/38321/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 38321: Adding upgrade specifications to docs for
'.json' endpoints
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38321/#review98733
-----------------------------------------------------------
Just a few minor tweaks and it'll be ready to ship.
docs/upgrades.md (line 11)
<https://reviews.apache.org/r/38321/#comment155302>
Please make it clear that the old endpoints are still available in 0.25, but will be removed in a future release.
docs/upgrades.md (lines 13 - 14)
<https://reviews.apache.org/r/38321/#comment155306>
You may need a blank line before your lists so that they render properly.
docs/upgrades.md (line 17)
<https://reviews.apache.org/r/38321/#comment155303>
s/agent/slave/ since all the existing docs still use "slave". We can make a pass over all docs in the future to make them consistent.
docs/upgrades.md (line 21)
<https://reviews.apache.org/r/38321/#comment155304>
s/agent/slave/
docs/upgrades.md (line 26)
<https://reviews.apache.org/r/38321/#comment155305>
Please use double-blank lines between upgrade sections.
- Adam B
On Sept. 11, 2015, 2:51 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38321/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 2:51 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding a Note for the deprecation of endpoints with '.json' extension.
>
>
> Diffs
> -----
>
> docs/upgrades.md c4b2880
>
> Diff: https://reviews.apache.org/r/38321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38321: Adding upgrade specifications to docs for
'.json' endpoints
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38321/#review98731
-----------------------------------------------------------
docs/upgrades.md (line 9)
<https://reviews.apache.org/r/38321/#comment155300>
Should be 0.25.x
- Guangya Liu
On 九月 11, 2015, 9:51 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38321/
> -----------------------------------------------------------
>
> (Updated 九月 11, 2015, 9:51 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding a Note for the deprecation of endpoints with '.json' extension.
>
>
> Diffs
> -----
>
> docs/upgrades.md c4b2880
>
> Diff: https://reviews.apache.org/r/38321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38321: Adding upgrade specifications to docs for
'.json' endpoints
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38321/#review98753
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36126, 36125, 36127, 38321]
All tests passed.
- Mesos ReviewBot
On Sept. 12, 2015, 6:08 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38321/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2015, 6:08 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding a Note for the deprecation of endpoints with '.json' extension.
>
>
> Diffs
> -----
>
> docs/upgrades.md c4b2880
>
> Diff: https://reviews.apache.org/r/38321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38321: Adding upgrade specifications to docs for
'.json' endpoints
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38321/
-----------------------------------------------------------
(Updated Sept. 12, 2015, 6:08 p.m.)
Review request for mesos and Adam B.
Repository: mesos
Description
-------
Adding a Note for the deprecation of endpoints with '.json' extension.
Diffs (updated)
-----
docs/upgrades.md c4b2880
Diff: https://reviews.apache.org/r/38321/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 38321: Adding upgrade specifications to docs for
'.json' endpoints
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38321/#review98725
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36126, 36125, 36127, 38321]
All tests passed.
- Mesos ReviewBot
On Sept. 11, 2015, 9:51 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38321/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 9:51 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding a Note for the deprecation of endpoints with '.json' extension.
>
>
> Diffs
> -----
>
> docs/upgrades.md c4b2880
>
> Diff: https://reviews.apache.org/r/38321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>