[GitHub] [spark] HeartSaVioR edited a comment on issue #24050: [MINOR][SQL] Deduplicate codes reading from/writing to unsafe object

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #24050: [MINOR][SQL] Deduplicate codes reading from/writing to unsafe object
URL: https://github.com/apache/spark/pull/24050#issuecomment-471430025
 
 
   Given this is a kind of refactor, I've put this into `MINOR`, but I will file an issue if we see needs on filing new issue.
   
   It would add couple of static method calls: I feel they don't contribute performance hit even they're in critical path, but I could run some benchmarks and update here if we have any.
   
   #24016 is a sibling refactor PR, and I'll merge into one if we think that's helpful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org