[GitHub] [daffodil] stevedlawrence commented on a change in pull request #773: Cleanup solarcloud warning. Remove do-while(false) local block workar…

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #773:
URL: https://github.com/apache/daffodil/pull/773#discussion_r826303735



##########
File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunables2.scala
##########
@@ -107,8 +106,8 @@ class TestCLITunables2 {
       } finally {
         shell.close()
       }
-    } while (false) // workaround scala local block bug.
-    do {

Review comment:
       Since you're making this change, can you also update to use `expectIn` instead of `expect` so we can remove the redirect? My concern is redirecting the input is going to cause stderr and stdout mixed up and might cause random failures when expecting strings depending on how things get mixed up. Might not actually be possible, but it's maybe good practice to avoid the redirect in favor of expectIn.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org