Re: bug: selectDistinct(List items) in apache-openjpa-2.0.0-SNAPSHOT

[Pinaki Poddar <pp...@apache.org>]

Hi,
  Thanks.
   done...

$ svn commit -m "Oversight in QueryDefinition.selectDistinct() boolean
argument corrected"
openjpa-persistence\src\main\java\org\apache\openjpa\persistence\query\QueryDefinitionImpl.java
Committed revision 747848.




Tan Shuai wrote:
> 
>>
>> I think it is a bug in
>> org.apache.openjpa.persistence.query.QueryDefinitionImpl, can we fix it?
>>
>>  public QueryDefinition selectDistinct(SelectItem... items) {
>>   return select(items == null ? null : Arrays.asList(items), true);
>>  }
>>  public QueryDefinition selectDistinct(List<SelectItem> items) {
>>   return select(items, false);
>>  }
>>
>>  private QueryDefinition select(List<SelectItem> items, boolean
>> isDistinct)
>> {
>>   if (_projections == null) {
>>    _projections = new ArrayList<SelectItem>();
>>   } else {
>>    _projections.clear();
>>   }
>>   _distinct = isDistinct;
>>   for (SelectItem item : items)
>>    _projections.add(item);
>>   return this;
>>  }
>>
> 
> 

-- 
View this message in context: http://n2.nabble.com/Re%3A-bug%3A-selectDistinct%28List%3CSelectItem%3E-items%29-in--apache-openjpa-2.0.0-SNAPSHOT-tp2382144p2384626.html
Sent from the OpenJPA Users mailing list archive at Nabble.com.