You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by eb...@apache.org on 2013/11/25 14:14:25 UTC

svn commit: r1545253 - in /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png: PngCrc.java PngWriter.java

Author: ebourg
Date: Mon Nov 25 13:14:25 2013
New Revision: 1545253

URL: http://svn.apache.org/r1545253
Log:
Private methods are implicitly final

Modified:
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngCrc.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngCrc.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngCrc.java?rev=1545253&r1=1545252&r2=1545253&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngCrc.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngCrc.java Mon Nov 25 13:14:25 2013
@@ -49,7 +49,7 @@ public class PngCrc {
      * of the final running CRC (see the crc() routine below)).
      */
 
-    private final long update_crc(final long crc, final byte buf[]) {
+    private long update_crc(final long crc, final byte buf[]) {
         long c = crc;
         int n;
 

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java?rev=1545253&r1=1545252&r2=1545253&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java Mon Nov 25 13:14:25 2013
@@ -63,14 +63,14 @@ public class PngWriter {
      5. Time information: tIME (see 11.3.6: Time stamp information).
     */
     
-    private final void writeInt(final OutputStream os, final int value) throws IOException {
+    private void writeInt(final OutputStream os, final int value) throws IOException {
         os.write(0xff & (value >> 24));
         os.write(0xff & (value >> 16));
         os.write(0xff & (value >> 8));
         os.write(0xff & (value >> 0));
     }
 
-    private final void writeChunk(final OutputStream os, final byte chunkType[],
+    private void writeChunk(final OutputStream os, final byte chunkType[],
             final byte data[]) throws IOException {
         final int dataLength = data == null ? 0 : data.length;
         writeInt(os, dataLength);