You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by ja...@apache.org on 2025/11/19 07:22:43 UTC

(mynewt-core) 01/03: sys/config/selftest: Fix memory leak

This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git

commit b8df3dd6ce67968ba07578109ebe243c756b712b
Author: Szymon Janc <sz...@codecoup.pl>
AuthorDate: Tue Nov 18 11:19:24 2025 +0100

    sys/config/selftest: Fix memory leak
    
    buf was never freed.
---
 sys/config/selftest-nffs/src/conf_test_nffs.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/sys/config/selftest-nffs/src/conf_test_nffs.c b/sys/config/selftest-nffs/src/conf_test_nffs.c
index 12c5b1193..6ea47ad48 100644
--- a/sys/config/selftest-nffs/src/conf_test_nffs.c
+++ b/sys/config/selftest-nffs/src/conf_test_nffs.c
@@ -169,10 +169,14 @@ conf_test_file_strstr(const char *fname, char *string)
     buf[rlen] = '\0';
 
     if (strstr(buf, string)) {
-        return 0;
+        rc = 0;
     } else {
-        return -1;
+        rc = -1;
     }
+
+    free(buf);
+
+    return rc;
 }
 
 void config_test_fill_area(char test_value[64][CONF_MAX_VAL_LEN],