You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/01/06 04:19:46 UTC

[jira] Created: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Addition of internode buffering broke Streaming
-----------------------------------------------

                 Key: CASSANDRA-1943
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
             Project: Cassandra
          Issue Type: Bug
            Reporter: Stu Hood
            Priority: Critical
             Fix For: 0.7.0


Adding internode buffering broke StreamingTransferTest in the 0.7.0 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1943:
--------------------------------

    Attachment: 0.6-0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt

And a version rebased for 0.6

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.10, 0.7.1
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.6.10, 0.7.1, 0.8
>
>         Attachments: 0.6-0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt, 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978607#action_12978607 ] 

Hudson commented on CASSANDRA-1943:
-----------------------------------

Integrated in Cassandra-0.6 #48 (See [https://hudson.apache.org/hudson/job/Cassandra-0.6/48/])
    Don't begin buffering a connection until we've determined the type.
Patch by Stu Hood, reviewed by gdusbabek for CASSANDRA-1943


> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.10, 0.7.1
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.6.10, 0.7.1, 0.8
>
>         Attachments: 0.6-0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt, 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1943:
--------------------------------------

             Reviewer: gdusbabek
          Component/s: Core
    Affects Version/s: 0.7.1
                       0.6.10

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.10, 0.7.1
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.6.10, 0.7.1, 0.8
>
>         Attachments: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1943:
--------------------------------------

    Fix Version/s:     (was: 0.8)

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.10, 0.7.1
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.6.10, 0.7.1
>
>         Attachments: 0.6-0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt, 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1943:
-------------------------------------

    Fix Version/s: 0.6.10

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.6.10, 0.7.1, 0.8
>
>         Attachments: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-1943:
----------------------------------------

    Fix Version/s:     (was: 0.7.0)
                   0.7.1

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.7.1
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7.0 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1943:
--------------------------------

    Description: Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313  (was: Adding internode buffering broke StreamingTransferTest in the 0.7.0 branch. Bisected to r1055313)

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.7.1
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978180#action_12978180 ] 

Stu Hood commented on CASSANDRA-1943:
-------------------------------------

Actually, the IOError we used to throw in the constructor should probably become a log statement like the other exceptions in run().

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.7.1, 0.8
>
>         Attachments: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978520#action_12978520 ] 

Gary Dusbabek commented on CASSANDRA-1943:
------------------------------------------

+1

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.6.10, 0.7.1, 0.8
>
>         Attachments: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1943:
--------------------------------

    Attachment: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt

Streaming connections don't use the InputStream implementation to read their data: they bypass all buffering and use the SocketChannel directly. By buffering immediately after opening the connection, we were buffering in the beginning of the streamed file.

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.7.1
>
>         Attachments: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1943) Addition of internode buffering broke Streaming

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-1943:
--------------------------------

    Fix Version/s: 0.8

Also affects trunk.

> Addition of internode buffering broke Streaming
> -----------------------------------------------
>
>                 Key: CASSANDRA-1943
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1943
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Priority: Critical
>             Fix For: 0.7.1, 0.8
>
>         Attachments: 0001-Don-t-begin-buffering-a-connection-until-we-ve-determi.txt
>
>
> Adding internode buffering broke StreamingTransferTest in the 0.7 branch. Bisected to r1055313

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.