You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/12/05 21:58:27 UTC

[GitHub] eolivelli commented on a change in pull request #1865: Ledger manager factories initialized with max metadata version

eolivelli commented on a change in pull request #1865: Ledger manager factories initialized with max metadata version
URL: https://github.com/apache/bookkeeper/pull/1865#discussion_r239253511
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
 ##########
 @@ -85,7 +85,6 @@
     protected static final String STORE_SYSTEMTIME_AS_LEDGER_UNDERREPLICATED_MARK_TIME =
             "storeSystemTimeAsLedgerUnderreplicatedMarkTime";
     protected static final String STORE_SYSTEMTIME_AS_LEDGER_CREATION_TIME = "storeSystemTimeAsLedgerCreationTime";
-    protected static final String MAX_LEDGER_METADATA_FORMAT_VERSION = "maxLedgerMetadataFormatVersion";
 
 Review comment:
   I miss one piece of this new story.
   How does the use configure this field? In order to force an older version because of the presence of a mix of old and new clients in the cluster?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services