You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/07/14 05:07:43 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24694: chore: Remove obsolete legacy visualizations
codecov[bot] commented on PR #24694:
URL: https://github.com/apache/superset/pull/24694#issuecomment-1635279341
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24694](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2477fdf) into [master](https://app.codecov.io/gh/apache/superset/commit/a156816064c47b9ad12f34571f44e02cfb72fe75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a156816) will **decrease** coverage by `10.79%`.
> The diff coverage is `17.77%`.
> :exclamation: Current head 2477fdf differs from pull request most recent head 1163f6d. Consider uploading reports for the commit 1163f6d to get more accurate results
```diff
@@ Coverage Diff @@
## master #24694 +/- ##
===========================================
- Coverage 68.97% 58.18% -10.79%
===========================================
Files 1902 1901 -1
Lines 74007 73926 -81
Branches 8186 8182 -4
===========================================
- Hits 51047 43017 -8030
- Misses 20839 28788 +7949
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.05% <9.30%> (+0.02%)` | :arrow_up: |
| python | `60.90% <16.27%> (-22.56%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.87% <16.27%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `61.38% <0.00%> (-32.42%)` | :arrow_down: |
| [superset/views/base.py](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `58.66% <ø> (-14.67%)` | :arrow_down: |
| [superset/viz.py](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdml6LnB5) | `29.92% <ø> (-36.98%)` | :arrow_down: |
| [superset/common/query\_context\_processor.py](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHRfcHJvY2Vzc29yLnB5) | `59.25% <7.14%> (-30.71%)` | :arrow_down: |
| [.../plugin-chart-pivot-table/src/plugin/buildQuery.ts](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3BsdWdpbi9idWlsZFF1ZXJ5LnRz) | `73.33% <50.00%> (+1.90%)` | :arrow_up: |
| [superset/datasets/schemas.py](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.59% <60.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `32.75% <100.00%> (-37.60%)` | :arrow_down: |
... and [288 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24694/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org