You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by colindean <gi...@git.apache.org> on 2018/11/19 04:17:49 UTC
[GitHub] nifi pull request #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs w...
GitHub user colindean opened a pull request:
https://github.com/apache/nifi/pull/3177
NIFI-5828: Documents behavior of ExecuteSQL attrs when Max Rows Per Flow File is enabled
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] ~Have you written or updated unit tests to verify your changes?~
- [ ] ~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~
- [ ] ~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~
- [ ] ~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~
- [ ] ~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/colindean/nifi nifi-5828-doc-max-rows-per-flowfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3177
----
commit 0c6995f35b24ddfab05bc103d48b2a97e3f8c336
Author: Colin Dean <co...@...>
Date: 2018-11-19T04:14:55Z
NIFI-5828: Documents behavior of ExecuteSQL attrs when Max Rows Per Flow File is enabled
----
---
[GitHub] nifi issue #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs when Max...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/3177
LGTM +1, merging. Thanks @colindean !
---
[GitHub] nifi issue #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs when Max...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/3177
@colindean mind closing this PR? Doesn't look like the comment in the commit caused it to auto-close (maybe the period after the PR number?) Please and thanks! Also I updated the Fix Version to be 1.9.0 as 1.8.0 was already released
---
[GitHub] nifi pull request #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3177
---