You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/07 10:45:42 UTC
[GitHub] [flink] Myracle opened a new pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Myracle opened a new pull request #18296:
URL: https://github.com/apache/flink/pull/18296
## What is the purpose of the change
*When the config high-availability.zookeeper.client.tolerate-suspended-connections is default false, the appMaster will failover once zk leader changes. In this case, the old appMaster will clean up all the HA data and the new appMaster will not recover from the latest checkpoint. We will fix it.*
## Brief change log
- *When cluster is shutting down with ApplicationStatus.UNKNOWN, cleanupHaData will be set false to retain HA data.*
## Verifying this change
This change added tests and can be verified as follows:
- *Added test that validates that HA data will not be cleanup after the cluster finished with ApplicationStatus.UNKNOWN.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1022786201
@tillrohrmann Sorry for late reply. I have written the most code and will finish it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155)
* ac842b597501d4f7d53967fb3f12e5288ea65674 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #18296:
URL: https://github.com/apache/flink/pull/18296#discussion_r784916201
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
##########
@@ -177,6 +177,34 @@ public void testTerminationAfterJobCompletion() throws Exception {
}
}
+ /**
+ * Tests that in detached mode, the {@link MiniDispatcher} will not complete the future that
+ * signals job termination if the JobStatus is not globally terminal state.
+ */
+ @Test
+ public void testNotTerminationWithoutGloballyTerminalState() throws Exception {
Review comment:
the test passes without the fix as well
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -124,16 +125,23 @@ protected CleanupJobState jobReachedTerminalState(ExecutionGraphInfo executionGr
executionGraphInfo.getArchivedExecutionGraph();
final CleanupJobState cleanupHAState = super.jobReachedTerminalState(executionGraphInfo);
- if (jobCancelled || executionMode == ClusterEntrypoint.ExecutionMode.DETACHED) {
+ JobStatus jobStatus = archivedExecutionGraph.getState();
+ if ((jobStatus != null && jobStatus.isGloballyTerminalState())
+ && (jobCancelled || executionMode == ClusterEntrypoint.ExecutionMode.DETACHED)) {
// shut down if job is cancelled or we don't have to wait for the execution result
// retrieval
log.info(
"Shutting down cluster with state {}, jobCancelled: {}, executionMode: {}",
- archivedExecutionGraph.getState(),
+ jobStatus,
+ jobCancelled,
+ executionMode);
+ shutDownFuture.complete(ApplicationStatus.fromJobStatus(jobStatus));
+ } else {
+ log.warn(
Review comment:
Why do we need to print a warning here?
Always try to think about it from the user perspective. If users sees this log message, is it relevant to what's going on? Is it something he / she should investigate?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -124,16 +125,23 @@ protected CleanupJobState jobReachedTerminalState(ExecutionGraphInfo executionGr
executionGraphInfo.getArchivedExecutionGraph();
final CleanupJobState cleanupHAState = super.jobReachedTerminalState(executionGraphInfo);
- if (jobCancelled || executionMode == ClusterEntrypoint.ExecutionMode.DETACHED) {
+ JobStatus jobStatus = archivedExecutionGraph.getState();
+ if ((jobStatus != null && jobStatus.isGloballyTerminalState())
Review comment:
Can the job status be null here? My intuition would be that for the terminal state this should never be the case and would actually signal an underlying issue. Maybe adding a safeguard (`Objects.requireNonNull`) with a reasonable message could a better fit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac842b597501d4f7d53967fb3f12e5288ea65674 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213)
* 6ffad613830a3d192c5f522b520c540a656698cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle removed a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle removed a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1022977945
>
It is a good suggestion and I have followed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
}, {
"hash" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381",
"triggerID" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"triggerType" : "PUSH"
}, {
"hash" : "226244d961f749ff16d7d8e8c33a4debc2170334",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30444",
"triggerID" : "226244d961f749ff16d7d8e8c33a4debc2170334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 226244d961f749ff16d7d8e8c33a4debc2170334 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30444)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094)
* e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac842b597501d4f7d53967fb3f12e5288ea65674 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213)
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
}, {
"hash" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381",
"triggerID" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"triggerType" : "PUSH"
}, {
"hash" : "226244d961f749ff16d7d8e8c33a4debc2170334",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30444",
"triggerID" : "226244d961f749ff16d7d8e8c33a4debc2170334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 477c124ae1a19477f1a34f720f7baeea358f2a53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381)
* 226244d961f749ff16d7d8e8c33a4debc2170334 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30444)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
}, {
"hash" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
* 477c124ae1a19477f1a34f720f7baeea358f2a53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1012093122
@dmvk Could you review again? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1024863511
@dmvk Fixed and the CI passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1024068199
@dmvk Thanks for the valuable suggestions which make the code clean. I have modified the code. Could you please review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
}, {
"hash" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381",
"triggerID" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 477c124ae1a19477f1a34f720f7baeea358f2a53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1024148968
:( compile step is failing, `AT_LEAST_ONE_CHECKPOINT_COMPLETED` needs to be renamed (-> camel case). Sorry for confusing you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
* 216076e637786e195ddb52e902ca5d47ba3d0728 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on a change in pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on a change in pull request #18296:
URL: https://github.com/apache/flink/pull/18296#discussion_r793376407
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
##########
@@ -177,6 +177,34 @@ public void testTerminationAfterJobCompletion() throws Exception {
}
}
+ /**
+ * Tests that in detached mode, the {@link MiniDispatcher} will not complete the future that
+ * signals job termination if the JobStatus is not globally terminal state.
+ */
+ @Test
+ public void testNotTerminationWithoutGloballyTerminalState() throws Exception {
Review comment:
I have modified the code to test the shutDownFuture not finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1023132487
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007388314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac842b597501d4f7d53967fb3f12e5288ea65674 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007313770
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 16eed821099b21c4d7f0f440c8d3f70babccfff5 (Fri Jan 07 10:50:10 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
}, {
"hash" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381",
"triggerID" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"triggerType" : "PUSH"
}, {
"hash" : "226244d961f749ff16d7d8e8c33a4debc2170334",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "226244d961f749ff16d7d8e8c33a4debc2170334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 477c124ae1a19477f1a34f720f7baeea358f2a53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381)
* 226244d961f749ff16d7d8e8c33a4debc2170334 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #18296:
URL: https://github.com/apache/flink/pull/18296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007388314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094)
* e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1020903329
What's the state of this PR? Can we resolve the open comments to merge it soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1020903329
What's the state of this PR? Can we resolve the open comments to merge it soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1009553018
@dmvk Thanks for the review and suggestions. I agree with you that the the process should not exit in this case. I have modified the code. Could you review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1022977945
>
It is a good suggestion and I have followed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #18296:
URL: https://github.com/apache/flink/pull/18296#discussion_r794265194
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
+ final Deadline deadline = Deadline.fromNow(TIMEOUT);
+ final Configuration configuration = new Configuration();
+ configuration.set(HighAvailabilityOptions.HA_MODE, HighAvailabilityMode.ZOOKEEPER.name());
+ final TestingMiniClusterConfiguration clusterConfiguration =
+ TestingMiniClusterConfiguration.newBuilder()
+ .setConfiguration(configuration)
+ .build();
+ final EmbeddedHaServicesWithLeadershipControl haServices =
+ new EmbeddedHaServicesWithLeadershipControl(TestingUtils.defaultExecutor());
+
+ Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
+ long checkpointInterval = 500;
+ JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
+
+ final TestingMiniCluster.Builder clusterBuilder =
+ TestingMiniCluster.newBuilder(clusterConfiguration)
+ .setHighAvailabilityServicesSupplier(() -> haServices)
+ .setDispatcherResourceManagerComponentFactorySupplier(
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ newConfiguration));
+
+ try (final MiniCluster cluster = clusterBuilder.build()) {
+ // start mini cluster and submit the job
+ cluster.start();
+
+ // wait until job is running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+ CommonTestUtils.waitForAllTaskRunning(cluster, jobID, false);
+ CommonTestUtils.waitUntilCondition(
+ () -> queryCompletedCheckpoints(cluster, jobID) > 0L,
+ Deadline.fromNow(Duration.ofSeconds(30)),
+ checkpointInterval / 2);
+
+ final CompletableFuture<JobResult> firstJobResult = cluster.requestJobResult(jobID);
+ haServices.revokeDispatcherLeadership();
+ // make sure the leadership is revoked to avoid race conditions
+ Assertions.assertEquals(
+ ApplicationStatus.UNKNOWN, firstJobResult.get().getApplicationStatus());
+
+ haServices.grantDispatcherLeadership();
+
+ // job is suspended, wait until it's running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+
+ assertNotNull(
+ cluster.getArchivedExecutionGraph(jobID)
+ .get()
+ .getCheckpointStatsSnapshot()
+ .getLatestRestoredCheckpoint());
+
+ cluster.cancelJob(jobID);
+
+ // the cluster should shut down automatically once the application completes
+ CommonTestUtils.waitUntilCondition(() -> !cluster.isRunning(), deadline);
+ }
+ }
+
+ private JobID generateJobGraph(Configuration configuration, long checkpointInterval)
+ throws Exception {
+ final JobVertex jobVertex = new JobVertex("jobVertex");
+ jobVertex.setInvokableClass(
+ AdaptiveSchedulerClusterITCase.CheckpointingNoOpInvokable.class);
+ jobVertex.setParallelism(1);
+
+ final CheckpointCoordinatorConfiguration checkpointCoordinatorConfiguration =
+ CheckpointCoordinatorConfiguration.builder()
+ .setCheckpointInterval(checkpointInterval)
+ .build();
+ final JobCheckpointingSettings checkpointingSettings =
+ new JobCheckpointingSettings(checkpointCoordinatorConfiguration, null);
+ JobGraph jobGraph =
Review comment:
nit: all other fields are marked final
```suggestion
final JobGraph jobGraph =
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
##########
@@ -201,6 +203,37 @@ public void testTerminationAfterJobCompletion() throws Exception {
}
}
+ /**
+ * Tests that in detached mode, the {@link MiniDispatcher} will not complete the future that
+ * signals job termination if the JobStatus is not globally terminal state.
+ */
+ @Test
+ public void testNotTerminationWithoutGloballyTerminalState() throws Exception {
+ final MiniDispatcher miniDispatcher =
+ createMiniDispatcher(ClusterEntrypoint.ExecutionMode.DETACHED);
+ miniDispatcher.start();
+
+ try {
+ // wait until we have submitted the job
+ final TestingJobManagerRunner testingJobManagerRunner =
+ testingJobManagerRunnerFactory.takeCreatedJobManagerRunner();
+
+ testingJobManagerRunner.completeResultFuture(
+ new ExecutionGraphInfo(
+ new ArchivedExecutionGraphBuilder()
+ .setJobID(jobGraph.getJobID())
+ .setState(JobStatus.SUSPENDED)
+ .build()));
+
+ miniDispatcher.getShutDownFuture().get(3, TimeUnit.SECONDS);
+ fail("The shutDownFuture should not be done.");
+ } catch (TimeoutException ignored) {
+
Review comment:
We can speed this test up by assuming that the shutdown future would have been completed before JMR terminates (in failing scenario)
```suggestion
testingJobManagerRunner.getTerminationFuture().get();
Assertions.assertThat(miniDispatcher.getShutDownFuture()).isNotDone();
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
+ final Deadline deadline = Deadline.fromNow(TIMEOUT);
+ final Configuration configuration = new Configuration();
+ configuration.set(HighAvailabilityOptions.HA_MODE, HighAvailabilityMode.ZOOKEEPER.name());
+ final TestingMiniClusterConfiguration clusterConfiguration =
+ TestingMiniClusterConfiguration.newBuilder()
+ .setConfiguration(configuration)
+ .build();
+ final EmbeddedHaServicesWithLeadershipControl haServices =
+ new EmbeddedHaServicesWithLeadershipControl(TestingUtils.defaultExecutor());
+
+ Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
+ long checkpointInterval = 500;
+ JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
Review comment:
nit: finals + lower the checkpoint interval
```suggestion
final Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
final long checkpointInterval = 100;
final JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
+ final Deadline deadline = Deadline.fromNow(TIMEOUT);
+ final Configuration configuration = new Configuration();
+ configuration.set(HighAvailabilityOptions.HA_MODE, HighAvailabilityMode.ZOOKEEPER.name());
+ final TestingMiniClusterConfiguration clusterConfiguration =
+ TestingMiniClusterConfiguration.newBuilder()
+ .setConfiguration(configuration)
+ .build();
+ final EmbeddedHaServicesWithLeadershipControl haServices =
+ new EmbeddedHaServicesWithLeadershipControl(TestingUtils.defaultExecutor());
+
+ Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
+ long checkpointInterval = 500;
+ JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
+
+ final TestingMiniCluster.Builder clusterBuilder =
+ TestingMiniCluster.newBuilder(clusterConfiguration)
+ .setHighAvailabilityServicesSupplier(() -> haServices)
+ .setDispatcherResourceManagerComponentFactorySupplier(
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ newConfiguration));
+
+ try (final MiniCluster cluster = clusterBuilder.build()) {
+ // start mini cluster and submit the job
+ cluster.start();
+
+ // wait until job is running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+ CommonTestUtils.waitForAllTaskRunning(cluster, jobID, false);
+ CommonTestUtils.waitUntilCondition(
+ () -> queryCompletedCheckpoints(cluster, jobID) > 0L,
+ Deadline.fromNow(Duration.ofSeconds(30)),
+ checkpointInterval / 2);
+
+ final CompletableFuture<JobResult> firstJobResult = cluster.requestJobResult(jobID);
+ haServices.revokeDispatcherLeadership();
+ // make sure the leadership is revoked to avoid race conditions
+ Assertions.assertEquals(
+ ApplicationStatus.UNKNOWN, firstJobResult.get().getApplicationStatus());
+
+ haServices.grantDispatcherLeadership();
+
+ // job is suspended, wait until it's running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+
+ assertNotNull(
+ cluster.getArchivedExecutionGraph(jobID)
+ .get()
+ .getCheckpointStatsSnapshot()
+ .getLatestRestoredCheckpoint());
+
+ cluster.cancelJob(jobID);
+
+ // the cluster should shut down automatically once the application completes
+ CommonTestUtils.waitUntilCondition(() -> !cluster.isRunning(), deadline);
+ }
+ }
+
+ private JobID generateJobGraph(Configuration configuration, long checkpointInterval)
Review comment:
I really like this! Maybe a small suggestion on the naming to make the fact that we write the JG to the disk more explicit
```suggestion
private JobID generateAndPersistJobGraph(Configuration configuration, long checkpointInterval)
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
Review comment:
nit: There was an agreement by the community that junit5 should be used for the new tests. For this test it basically only means changing the test logger for extension, switching imports for `@Test` annotation and injecting temp directory as a parameter to the test case.
```suggestion
@ExtendWith(TestLoggerExtension.class)
public class JobDispatcherITCase {
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
+ final Deadline deadline = Deadline.fromNow(TIMEOUT);
+ final Configuration configuration = new Configuration();
+ configuration.set(HighAvailabilityOptions.HA_MODE, HighAvailabilityMode.ZOOKEEPER.name());
+ final TestingMiniClusterConfiguration clusterConfiguration =
+ TestingMiniClusterConfiguration.newBuilder()
+ .setConfiguration(configuration)
+ .build();
+ final EmbeddedHaServicesWithLeadershipControl haServices =
+ new EmbeddedHaServicesWithLeadershipControl(TestingUtils.defaultExecutor());
+
+ Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
+ long checkpointInterval = 500;
+ JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
+
+ final TestingMiniCluster.Builder clusterBuilder =
+ TestingMiniCluster.newBuilder(clusterConfiguration)
+ .setHighAvailabilityServicesSupplier(() -> haServices)
+ .setDispatcherResourceManagerComponentFactorySupplier(
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ newConfiguration));
+
+ try (final MiniCluster cluster = clusterBuilder.build()) {
+ // start mini cluster and submit the job
+ cluster.start();
+
+ // wait until job is running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+ CommonTestUtils.waitForAllTaskRunning(cluster, jobID, false);
+ CommonTestUtils.waitUntilCondition(
+ () -> queryCompletedCheckpoints(cluster, jobID) > 0L,
+ Deadline.fromNow(Duration.ofSeconds(30)),
+ checkpointInterval / 2);
+
+ final CompletableFuture<JobResult> firstJobResult = cluster.requestJobResult(jobID);
+ haServices.revokeDispatcherLeadership();
+ // make sure the leadership is revoked to avoid race conditions
+ Assertions.assertEquals(
+ ApplicationStatus.UNKNOWN, firstJobResult.get().getApplicationStatus());
+
+ haServices.grantDispatcherLeadership();
+
+ // job is suspended, wait until it's running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+
+ assertNotNull(
+ cluster.getArchivedExecutionGraph(jobID)
+ .get()
+ .getCheckpointStatsSnapshot()
+ .getLatestRestoredCheckpoint());
+
+ cluster.cancelJob(jobID);
+
+ // the cluster should shut down automatically once the application completes
+ CommonTestUtils.waitUntilCondition(() -> !cluster.isRunning(), deadline);
Review comment:
Do we need to test for this (it feels that we've already tested everything we needed to)? If not we can remove it to speed the test up a little bit.
```suggestion
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
+ final Deadline deadline = Deadline.fromNow(TIMEOUT);
+ final Configuration configuration = new Configuration();
+ configuration.set(HighAvailabilityOptions.HA_MODE, HighAvailabilityMode.ZOOKEEPER.name());
+ final TestingMiniClusterConfiguration clusterConfiguration =
+ TestingMiniClusterConfiguration.newBuilder()
+ .setConfiguration(configuration)
+ .build();
+ final EmbeddedHaServicesWithLeadershipControl haServices =
+ new EmbeddedHaServicesWithLeadershipControl(TestingUtils.defaultExecutor());
+
+ Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
+ long checkpointInterval = 500;
+ JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
+
+ final TestingMiniCluster.Builder clusterBuilder =
+ TestingMiniCluster.newBuilder(clusterConfiguration)
+ .setHighAvailabilityServicesSupplier(() -> haServices)
+ .setDispatcherResourceManagerComponentFactorySupplier(
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ newConfiguration));
+
Review comment:
(followup for the comment below)
```suggestion
AtLeastOneCheckpointInvokable.reset()
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
##########
@@ -177,6 +177,34 @@ public void testTerminationAfterJobCompletion() throws Exception {
}
}
+ /**
+ * Tests that in detached mode, the {@link MiniDispatcher} will not complete the future that
+ * signals job termination if the JobStatus is not globally terminal state.
+ */
+ @Test
+ public void testNotTerminationWithoutGloballyTerminalState() throws Exception {
Review comment:
👍
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
+ final Deadline deadline = Deadline.fromNow(TIMEOUT);
+ final Configuration configuration = new Configuration();
+ configuration.set(HighAvailabilityOptions.HA_MODE, HighAvailabilityMode.ZOOKEEPER.name());
+ final TestingMiniClusterConfiguration clusterConfiguration =
+ TestingMiniClusterConfiguration.newBuilder()
+ .setConfiguration(configuration)
+ .build();
+ final EmbeddedHaServicesWithLeadershipControl haServices =
+ new EmbeddedHaServicesWithLeadershipControl(TestingUtils.defaultExecutor());
+
+ Configuration newConfiguration = new Configuration(clusterConfiguration.getConfiguration());
+ long checkpointInterval = 500;
+ JobID jobID = generateJobGraph(newConfiguration, checkpointInterval);
+
+ final TestingMiniCluster.Builder clusterBuilder =
+ TestingMiniCluster.newBuilder(clusterConfiguration)
+ .setHighAvailabilityServicesSupplier(() -> haServices)
+ .setDispatcherResourceManagerComponentFactorySupplier(
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ newConfiguration));
+
+ try (final MiniCluster cluster = clusterBuilder.build()) {
+ // start mini cluster and submit the job
+ cluster.start();
+
+ // wait until job is running
+ awaitJobStatus(cluster, jobID, JobStatus.RUNNING, deadline);
+ CommonTestUtils.waitForAllTaskRunning(cluster, jobID, false);
+ CommonTestUtils.waitUntilCondition(
+ () -> queryCompletedCheckpoints(cluster, jobID) > 0L,
+ Deadline.fromNow(Duration.ofSeconds(30)),
+ checkpointInterval / 2);
Review comment:
```suggestion
AtLeastOneCheckpointInvokable.AT_LEAST_ONE_CHECKPOINT_COMPLETED.await();
```
I think we can simplify this a bit and get rid of few busy waiting loops by introducing a custom invokable, that waits for at least on checkpoint to complete.
```
/** An invokable that supports checkpointing and counts down when there is at least one checkpoint. */
public static class AtLeastOneCheckpointInvokable extends AdaptiveSchedulerClusterITCase.CheckpointingNoOpInvokable {
private static volatile CountDownLatch AT_LEAST_ONE_CHECKPOINT_COMPLETED;
private static void reset() {
AT_LEAST_ONE_CHECKPOINT_COMPLETED = new CountDownLatch(1);
}
public AtLeastOneCheckpointInvokable(Environment environment) {
super(environment);
}
@Override
public Future<Void> notifyCheckpointCompleteAsync(long checkpointId) {
AT_LEAST_ONE_CHECKPOINT_COMPLETED.countDown();
return CompletableFuture.completedFuture(null);
}
}
```
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobDispatcherITCase.java
##########
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobStatus;
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.HighAvailabilityOptions;
+import org.apache.flink.runtime.clusterframework.ApplicationStatus;
+import org.apache.flink.runtime.dispatcher.runner.DefaultDispatcherRunnerFactory;
+import org.apache.flink.runtime.dispatcher.runner.JobDispatcherLeaderProcessFactoryFactory;
+import org.apache.flink.runtime.entrypoint.component.DefaultDispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory;
+import org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever;
+import org.apache.flink.runtime.highavailability.nonha.embedded.EmbeddedHaServicesWithLeadershipControl;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphBuilder;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.tasks.CheckpointCoordinatorConfiguration;
+import org.apache.flink.runtime.jobgraph.tasks.JobCheckpointingSettings;
+import org.apache.flink.runtime.jobmanager.HighAvailabilityMode;
+import org.apache.flink.runtime.jobmaster.JobResult;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniCluster;
+import org.apache.flink.runtime.minicluster.TestingMiniClusterConfiguration;
+import org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerFactory;
+import org.apache.flink.runtime.rest.JobRestEndpointFactory;
+import org.apache.flink.runtime.scheduler.adaptive.AdaptiveSchedulerClusterITCase;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.util.ExceptionUtils;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.time.Duration;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.function.Supplier;
+
+import static java.nio.file.StandardOpenOption.CREATE;
+import static org.apache.flink.runtime.entrypoint.component.FileJobGraphRetriever.JOB_GRAPH_FILE_PATH;
+import static org.junit.Assert.assertNotNull;
+
+/** An integration test which recovers from checkpoint after regaining the leadership. */
+public class JobDispatcherITCase extends TestLogger {
+
+ private static final Duration TIMEOUT = Duration.ofMinutes(10);
+
+ @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+
+ private Supplier<DispatcherResourceManagerComponentFactory>
+ createJobModeDispatcherResourceManagerComponentFactorySupplier(
+ Configuration configuration) {
+ return () -> {
+ try {
+ return new DefaultDispatcherResourceManagerComponentFactory(
+ new DefaultDispatcherRunnerFactory(
+ JobDispatcherLeaderProcessFactoryFactory.create(
+ FileJobGraphRetriever.createFrom(configuration, null))),
+ StandaloneResourceManagerFactory.getInstance(),
+ JobRestEndpointFactory.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ };
+ }
+
+ @Test
+ public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership() throws Exception {
Review comment:
nit: follow up for the junit 5 comment
```suggestion
public void testRecoverFromCheckpointAfterLosingAndRegainingLeadership(@TempDir Path tmp) throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1023921156
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
}, {
"hash" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381",
"triggerID" : "477c124ae1a19477f1a34f720f7baeea358f2a53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
* 477c124ae1a19477f1a34f720f7baeea358f2a53 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30381)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155)
* ac842b597501d4f7d53967fb3f12e5288ea65674 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304",
"triggerID" : "1023921156",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"triggerType" : "PUSH"
}, {
"hash" : "216076e637786e195ddb52e902ca5d47ba3d0728",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282",
"triggerID" : "1023132487",
"triggerType" : "MANUAL"
}, {
"hash" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 216076e637786e195ddb52e902ca5d47ba3d0728 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30282)
* f098fea68223ed6e4ab3283bf9ebb35e8a26c3d8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myracle commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
Myracle commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1022786201
@tillrohrmann @dmvk I have just updated the code. Hope to merge it soon. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
}, {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29094",
"triggerID" : "1007388386",
"triggerType" : "MANUAL"
}, {
"hash" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29155",
"triggerID" : "e12d9741c67124c0b2f7ed76d59a3c52d5f0e28e",
"triggerType" : "PUSH"
}, {
"hash" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29213",
"triggerID" : "ac842b597501d4f7d53967fb3f12e5288ea65674",
"triggerType" : "PUSH"
}, {
"hash" : "6ffad613830a3d192c5f522b520c540a656698cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265",
"triggerID" : "6ffad613830a3d192c5f522b520c540a656698cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ffad613830a3d192c5f522b520c540a656698cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18296:
URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16eed821099b21c4d7f0f440c8d3f70babccfff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16eed821099b21c4d7f0f440c8d3f70babccfff5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org