[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #5936: [Minor]: Refactor row_hash implementation

["mustafasrepo (via GitHub)" <gi...@apache.org>]

mustafasrepo commented on code in PR #5936:
URL: https://github.com/apache/arrow-datafusion/pull/5936#discussion_r1161482679


##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -319,192 +499,31 @@ impl GroupedHashAggregateStream {
 
         let row_converter_size_pre = self.row_converter.size();
         for group_values in &group_by_values {
-            let group_rows = self.row_converter.convert_columns(group_values)?;

Review Comment:
   This chunk is moved to the function `update_group_state`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org