You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2024/08/22 21:26:00 UTC

[jira] [Resolved] (YUNIKORN-2582) Shim: Use atomic.Int32 for atomic operations

     [ https://issues.apache.org/jira/browse/YUNIKORN-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Condit resolved YUNIKORN-2582.
------------------------------------
    Fix Version/s: 1.6.0
       Resolution: Fixed

Merged to master. Thanks [~sophiesun] for the contribution.

> Shim: Use atomic.Int32 for atomic operations
> --------------------------------------------
>
>                 Key: YUNIKORN-2582
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2582
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Yu-Lin Chen
>            Assignee: Yun Sun
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 1.6.0
>
>
> Type atomic.Int32 was introduced in go 1.19, we should adopt it for better code clarity.
> Below variable type should be changed:
> 1. asyncDispatchCount in [dispatcher.go|https://github.com/apache/yunikorn-k8shim/blob/299816338caa1053e76e8f0d627321335d159cd2/pkg/dispatcher/dispatcher.go#L50]
> 2. registerCount/UpdateAllocationCount/UpdateApplicationCount/UpdateNodeCount in [schedulerapi_mock.go|https://github.com/apache/yunikorn-k8shim/blob/299816338caa1053e76e8f0d627321335d159cd2/pkg/common/test/schedulerapi_mock.go#L30-L33]
>  
> PS: This Jira is based on the discussion under YUNIKORN-2576.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org