You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 11:51:00 UTC
[jira] [Commented] (FLINK-7321) Remove Flink's futures from
HeartbeatManager
[ https://issues.apache.org/jira/browse/FLINK-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108765#comment-16108765 ]
ASF GitHub Bot commented on FLINK-7321:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4434#discussion_r130586473
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerTest.java ---
@@ -288,7 +286,11 @@ public void testTargetUnmonitoring() throws InterruptedException, ExecutionExcep
this.payload = payload;
}
- public Future<ResourceID> getTimeoutFuture() {
+ public CompletableFuture<ResourceID> getFuture() {
+ return future;
--- End diff --
True. This is a mistake. Thanks for catching.
> Remove Flink's futures from HeartbeatManager
> --------------------------------------------
>
> Key: FLINK-7321
> URL: https://issues.apache.org/jira/browse/FLINK-7321
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)