You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/09/03 22:07:15 UTC
[GitHub] [mynewt-newtmgr] ccollins476ad commented on a change in pull
request #143: [RFC] Add basic multi-image support
ccollins476ad commented on a change in pull request #143: [RFC] Add basic multi-image support
URL: https://github.com/apache/mynewt-newtmgr/pull/143#discussion_r320498529
##########
File path: nmxact/xact/image.go
##########
@@ -68,7 +69,7 @@ func (r *ImageUploadResult) Status() int {
}
func buildImageUploadReq(imageSz int, hash []byte, upgrade bool, chunk []byte,
- off int) *nmp.ImageUploadReq {
+ off int, image_num int) *nmp.ImageUploadReq {
Review comment:
Nitpick: Should this use camel case instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services