[GitHub] [pinot] navina commented on a diff in pull request #11017: Remove support for High level consumers in Apache Pinot

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #11017:
URL: https://github.com/apache/pinot/pull/11017#discussion_r1281425878


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -223,6 +212,17 @@ public StreamConfig(String tableNameWithType, Map<String, String> streamConfigMa
     _streamConfigMap.putAll(streamConfigMap);
   }
 
+  public static void validateConsumerType(String streamType, Map<String, String> streamConfigMap) {
+    String consumerTypesKey =
+        StreamConfigProperties.constructStreamProperty(streamType, StreamConfigProperties.STREAM_CONSUMER_TYPES);
+    String consumerTypes = streamConfigMap.get(consumerTypesKey);
+    Preconditions.checkNotNull(consumerTypes, consumerTypesKey + " cannot be null");
+    for (String consumerType : consumerTypes.split(",")) {
+      Preconditions.checkState(ConsumerType.LOWLEVEL.name().equalsIgnoreCase(consumerType)
+              || SIMPLE_CONSUMER_TYPE_STRING.equalsIgnoreCase(consumerType),

Review Comment:
   yes. and this precondition is allowing it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org