You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/08/20 23:00:53 UTC
[GitHub] incubator-brooklyn pull request: Adds Entity.sensors() to group th...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/861
Adds Entity.sensors() to group the sensor methods
- The attribute/sensor methods are all in Entity.sensors().
- Deprecates the previous things in Entity.* and EntityLocal.*,
except for getAttribute(AttributeSensor) which is left as a convenience.
- In EntityInternal.sensors(), it returns SensorSupportInternal
which has more methods on it.
There are three big motivations for this:
- Consistency with entity.config()
- Simplification of the Entity class (which has way too many methods)
by grouping them.
- Exposing the methods of EntityLocal on Entity, so we can
deprecate EntityLocal (this commit deals with just the attribute/sensor
methods of EntityLocal)
Note that I haven't changed any of the uses of the old attribute methods. I wanted to get feedback first as to whether people agreed this was the right thing to do!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn feature/add-Entity_sensors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #861
----
commit 938788656776f79be34443525b6c97f1f74b1667
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-20T20:59:57Z
Adds Entity.sensors() to group the sensor methods
- The attribute/sensor methods are all in Entity.sensors().
- Deprecates the previous things in Entity.* and EntityLocal.*,
except for getAttribute(AttributeSensor) which is left as a convenience.
- In EntityInternal.sensors(), it returns SensorSupportInternal
which has more methods on it.
There are three big motivations for this:
- Consistency with entity.config()
- Simplification of the Entity class (which has way too many methods)
by grouping them.
- Exposing the methods of EntityLocal on Entity, so we can
deprecate EntityLocal (this commit deals with just the attribute/sensor
methods of EntityLocal)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds Entity.sensors() to group th...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/861#issuecomment-133419988
Reviewed, tested, I was thinking of merging last night, but waited for more community input per @aledsage request. Thinking about it I think I am a bit more biased towards ```attributes()```, that express the ```what``` vs ```sensors()``` referring to the ```how```. Slight semantic difference. I am fine with either though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds Entity.sensors() to group th...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/861#issuecomment-133958189
Lazy consensus. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds Entity.sensors() to group th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/861
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds Entity.sensors() to group th...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/861#issuecomment-133433958
Sticking with autonomic terminology I am in favour of `sensors`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---