You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/11 02:34:40 UTC

[GitHub] [druid] suneet-s opened a new pull request #10170: Change color of Run button for native queries

suneet-s opened a new pull request #10170:
URL: https://github.com/apache/druid/pull/10170


   ### Description
   
   When a user tries to run a native query, change the color of the button to
   Druid's secondary color to indicate that the user is not running a SQL query.
   
   Before this change, the web-console would indicate this by changing the text
   of the button from Run (SQL queries) to Rune (native queries). Rune could be
   confusing to users as this appears to be a typo.
   SQL:
   <img width="415" alt="Screen Shot 2020-07-10 at 7 32 28 PM" src="https://user-images.githubusercontent.com/44787917/87214754-4c7fd700-c2e4-11ea-8159-358a88d81cf3.png">
   
   Native:
   <img width="387" alt="Screen Shot 2020-07-10 at 7 32 15 PM" src="https://user-images.githubusercontent.com/44787917/87214756-4db10400-c2e4-11ea-9494-e86ebff933ed.png">
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky commented on pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10170:
URL: https://github.com/apache/druid/pull/10170#issuecomment-659053011


   Awesome, TY! 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky merged pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #10170:
URL: https://github.com/apache/druid/pull/10170


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] maytasm commented on pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
maytasm commented on pull request #10170:
URL: https://github.com/apache/druid/pull/10170#issuecomment-658442246


   Is it better to rename the button to something like "Run native query" vs. "Run SQL query"? I don't think it is entirely obvious that a user will correlate the color of light green blue shade to native query


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on a change in pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10170:
URL: https://github.com/apache/druid/pull/10170#discussion_r453162433



##########
File path: web-console/src/views/query-view/run-button/run-button.scss
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+.rune-button {
+  background-color: #2ca89e !important

Review comment:
       ```suggestion
     background-color: #2ca89e !important;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10170:
URL: https://github.com/apache/druid/pull/10170#issuecomment-658452552


   > Is it better to rename the button to something like "Run native query" vs. "Run SQL query"? I don't think it is entirely obvious that a user will correlate the color of light green blue shade to native query
   
   I could change it, but it makes the button size change depending on which mode you're in. I don't think the web console is where most users would issue native queries from, so I'm ok with the UX being either way. I just like the color change since it makes it feel more like an easter egg.
   
   <img width="478" alt="Screen Shot 2020-07-14 at 3 44 43 PM" src="https://user-images.githubusercontent.com/44787917/87483767-658cce80-c5e9-11ea-9f61-19333a465e97.png">
   
   In the "..." button it links to the native query documentation so if someone was really confused, I guess they could look at that button. LMK which approach I should take


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on a change in pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10170:
URL: https://github.com/apache/druid/pull/10170#discussion_r454674347



##########
File path: web-console/src/views/query-view/run-button/run-button.tsx
##########
@@ -151,25 +153,34 @@ export class RunButton extends React.PureComponent<RunButtonProps> {
 
   render(): JSX.Element {
     const { runeMode, onRun, loading } = this.props;
-    const runButtonText = 'Run' + (runeMode ? 'e' : '');
 
     return (
       <ButtonGroup className="run-button">
         {onRun ? (
           <Tooltip content="Control + Enter" hoverOpenDelay={900}>
             <Button
+              className={runeMode ? 'rune-button' : ''}

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on a change in pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10170:
URL: https://github.com/apache/druid/pull/10170#discussion_r453153529



##########
File path: web-console/src/views/query-view/run-button/run-button.scss
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+.rune-button {
+  background-color: #2CA89E !important

Review comment:
       ```suggestion
     background-color: #2ca89e !important
   ```

##########
File path: web-console/src/views/query-view/run-button/run-button.scss
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+.rune-button {
+  background-color: #2CA89E !important
+}

Review comment:
       ```suggestion
   }
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky commented on a change in pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #10170:
URL: https://github.com/apache/druid/pull/10170#discussion_r454657290



##########
File path: web-console/src/views/query-view/run-button/run-button.scss
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+.rune-button {

Review comment:
       This should be nested within `.run-button {` to avoid collisions with other `rune-button`s in the app.
   In general the content of every scss file is nested within a selector of the same name.

##########
File path: web-console/src/views/query-view/run-button/run-button.tsx
##########
@@ -151,25 +153,34 @@ export class RunButton extends React.PureComponent<RunButtonProps> {
 
   render(): JSX.Element {
     const { runeMode, onRun, loading } = this.props;
-    const runButtonText = 'Run' + (runeMode ? 'e' : '');
 
     return (
       <ButtonGroup className="run-button">
         {onRun ? (
           <Tooltip content="Control + Enter" hoverOpenDelay={900}>
             <Button
+              className={runeMode ? 'rune-button' : ''}

Review comment:
       Doing `className={runeMode ? 'rune-button' : undefined}` here would be more idiomatic.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on a change in pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10170:
URL: https://github.com/apache/druid/pull/10170#discussion_r453153619



##########
File path: web-console/src/views/query-view/run-button/run-button.scss
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+.rune-button {
+  background-color: #2ca89e !important
+}

Review comment:
       ```suggestion
   }
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] suneet-s commented on a change in pull request #10170: Change color of Run button for native queries

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10170:
URL: https://github.com/apache/druid/pull/10170#discussion_r453144924



##########
File path: web-console/src/views/query-view/run-button/run-button.tsx
##########
@@ -151,25 +153,34 @@ export class RunButton extends React.PureComponent<RunButtonProps> {
 
   render(): JSX.Element {
     const { runeMode, onRun, loading } = this.props;
-    const runButtonText = 'Run' + (runeMode ? 'e' : '');
 
     return (
       <ButtonGroup className="run-button">
         {onRun ? (
           <Tooltip content="Control + Enter" hoverOpenDelay={900}>
             <Button
+              className={runeMode ? 'rune-button' : ''}

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org