[GitHub] [spark] tgravescs commented on pull request #40843: [SPARK-43179][SHUFFLE] Allowing apps to control whether their metadata gets saved in the db by the External Shuffle Service

["tgravescs (via GitHub)" <gi...@apache.org>]

tgravescs commented on PR #40843:
URL: https://github.com/apache/spark/pull/40843#issuecomment-1514983363

   so the intention here is it still uses external shuffle service but doesn't store the secret so if node manager goes down it can't recover that, correct?
     
   Personally I'm fine with adding this option, you also need to add documentation for this new configuration in .md file with explanation why you would want to disable it.  I'm wondering if we want something in the security doc about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org