You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/10/25 06:48:38 UTC
[kudu-CR](branch-1.8.x) [c++ client] clean up inline doxygen documentation
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Adar Dembo, Anonymous Coward (314),
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11783
to review the following change.
Change subject: [c++ client] clean up inline doxygen documentation
......................................................................
[c++ client] clean up inline doxygen documentation
This patch cleans up doxygen documentation in client.h.
Most importantly, this patch removes the internal API
methods (i.e. methods marked with KUDU_NO_EXPORT attribute)
from the auto-generated documentation. Fixed other typos
and mistakes in doxygen formatting, so now doxygen outputs
less warnings.
The rest of the doxygen warnings will be addressed in a follow-up
patch.
Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Reviewed-on: http://gerrit.cloudera.org:8080/11780
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit a30c9211e8e73ead70acdb6108e5a0eac90cb5cb)
---
M src/kudu/client/client.h
1 file changed, 68 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11783/1
--
To view, visit http://gerrit.cloudera.org:8080/11783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Gerrit-Change-Number: 11783
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) [c++ client] clean up inline doxygen documentation
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11783 )
Change subject: [c++ client] clean up inline doxygen documentation
......................................................................
[c++ client] clean up inline doxygen documentation
This patch cleans up doxygen documentation in client.h.
Most importantly, this patch removes the internal API
methods (i.e. methods marked with KUDU_NO_EXPORT attribute)
from the auto-generated documentation. Fixed other typos
and mistakes in doxygen formatting, so now doxygen outputs
less warnings.
The rest of the doxygen warnings will be addressed in a follow-up
patch.
Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Reviewed-on: http://gerrit.cloudera.org:8080/11780
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit a30c9211e8e73ead70acdb6108e5a0eac90cb5cb)
Reviewed-on: http://gerrit.cloudera.org:8080/11783
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 53 insertions(+), 21 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Gerrit-Change-Number: 11783
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) [c++ client] clean up inline doxygen documentation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11783 )
Change subject: [c++ client] clean up inline doxygen documentation
......................................................................
Patch Set 2: Code-Review+2
> Let me also cherry-pick 9db9021 in the 1.8.x branch as well -- that
> precedes a30c921 and I don't see why we wouldn't want to have it in
> 1.8.x as well.
Woops, sorry -- a30c921 was about a method that didn't get into 1.8.x. Please ignore my prior comment.
--
To view, visit http://gerrit.cloudera.org:8080/11783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Gerrit-Change-Number: 11783
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:17:49 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) [c++ client] clean up inline doxygen documentation
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Adar Dembo, Anonymous Coward (314),
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11783
to look at the new patch set (#2).
Change subject: [c++ client] clean up inline doxygen documentation
......................................................................
[c++ client] clean up inline doxygen documentation
This patch cleans up doxygen documentation in client.h.
Most importantly, this patch removes the internal API
methods (i.e. methods marked with KUDU_NO_EXPORT attribute)
from the auto-generated documentation. Fixed other typos
and mistakes in doxygen formatting, so now doxygen outputs
less warnings.
The rest of the doxygen warnings will be addressed in a follow-up
patch.
Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Reviewed-on: http://gerrit.cloudera.org:8080/11780
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit a30c9211e8e73ead70acdb6108e5a0eac90cb5cb)
---
M src/kudu/client/client.h
1 file changed, 53 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/11783/2
--
To view, visit http://gerrit.cloudera.org:8080/11783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Gerrit-Change-Number: 11783
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) [c++ client] clean up inline doxygen documentation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11783 )
Change subject: [c++ client] clean up inline doxygen documentation
......................................................................
Patch Set 2:
Let me also cherry-pick 9db9021 in the 1.8.x branch as well -- that precedes a30c921 and I don't see why we wouldn't want to have it in 1.8.x as well.
--
To view, visit http://gerrit.cloudera.org:8080/11783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0038f45e746896b6abbcfaa5741760218d7a9ad
Gerrit-Change-Number: 11783
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:14:33 +0000
Gerrit-HasComments: No