You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "WZhuo (via GitHub)" <gi...@apache.org> on 2025/12/31 07:02:35 UTC
[PR] fix: escape for getting string literal [iceberg-cpp]
WZhuo opened a new pull request, #468:
URL: https://github.com/apache/iceberg-cpp/pull/468
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: escape for getting string literal [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #468:
URL: https://github.com/apache/iceberg-cpp/pull/468#discussion_r2654952807
##########
src/iceberg/test/literal_test.cc:
##########
@@ -546,9 +546,9 @@ INSTANTIATE_TEST_SUITE_P(
.expected_type_id = TypeId::kDecimal,
.expected_string = "0"},
BasicLiteralTestParam{.test_name = "String",
- .literal = Literal::String("hello world"),
+ .literal = Literal::String("hello \" world"),
.expected_type_id = TypeId::kString,
- .expected_string = "\"hello world\""},
+ .expected_string = "\"hello \\\" world\""},
Review Comment:
Should it be escaped as `hello%20%22%20world`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: return raw string for StringType literal [iceberg-cpp]
Posted by "WZhuo (via GitHub)" <gi...@apache.org>.
WZhuo closed pull request #468: fix: return raw string for StringType literal
URL: https://github.com/apache/iceberg-cpp/pull/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: escape for getting string literal [iceberg-cpp]
Posted by "WZhuo (via GitHub)" <gi...@apache.org>.
WZhuo commented on code in PR #468:
URL: https://github.com/apache/iceberg-cpp/pull/468#discussion_r2660154504
##########
src/iceberg/test/literal_test.cc:
##########
@@ -546,9 +546,9 @@ INSTANTIATE_TEST_SUITE_P(
.expected_type_id = TypeId::kDecimal,
.expected_string = "0"},
BasicLiteralTestParam{.test_name = "String",
- .literal = Literal::String("hello world"),
+ .literal = Literal::String("hello \" world"),
.expected_type_id = TypeId::kString,
- .expected_string = "\"hello world\""},
+ .expected_string = "\"hello \\\" world\""},
Review Comment:
I think it's somehow like json literal. `true`, `false` for bool type, `1234` for integer and also json dump for string type, `"hello \" world"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: escape for getting string literal [iceberg-cpp]
Posted by "WZhuo (via GitHub)" <gi...@apache.org>.
WZhuo commented on code in PR #468:
URL: https://github.com/apache/iceberg-cpp/pull/468#discussion_r2660154504
##########
src/iceberg/test/literal_test.cc:
##########
@@ -546,9 +546,9 @@ INSTANTIATE_TEST_SUITE_P(
.expected_type_id = TypeId::kDecimal,
.expected_string = "0"},
BasicLiteralTestParam{.test_name = "String",
- .literal = Literal::String("hello world"),
+ .literal = Literal::String("hello \" world"),
.expected_type_id = TypeId::kString,
- .expected_string = "\"hello world\""},
+ .expected_string = "\"hello \\\" world\""},
Review Comment:
I think it's somehow like json literal. `true`, `false` for bool type, `1234` for integer and also json dump for string type, `"hello\"world"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org