You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:57:48 UTC
[GitHub] [incubator-devlake] likyh opened a new issue, #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
likyh opened a new issue, #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
### What you expected to happen
I think config-ui should allow me add any plugin
### How to reproduce
1. create blueprint
2. click advance mode
3. try to edit plugin in json
### Anything else
_No response_
### Version
v0.13.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055#issuecomment-1244875546
> @likyh For the moment, "bitbucket" is new plugin and needs to be added to the list of "Allowed Providers" In Advanced mode. This validation is there to prevent invalid plugins from being manually entered via json.
I think we should allow all name in here. Because maybe user will load his private plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055#issuecomment-1260336370
Re-assigned to @mintsweet, Will be resolved by #3209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055#issuecomment-1244867544
@likyh For the moment, "bitbucket" is new plugin and needs to be added to the list of "Allowed Providers" In Advanced mode. This validation is there to prevent invalid plugins from being manually entered via json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn closed issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
abeizn closed issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
URL: https://github.com/apache/incubator-devlake/issues/3055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055#issuecomment-1244877830
> > > @likyh For the moment, "bitbucket" is new plugin and needs to be added to the list of "Allowed Providers" In Advanced mode. This validation is there to prevent invalid plugins from being manually entered via json.
> >
> >
> > I think we should allow all name in here. Because maybe user will load his private plugin.
>
> I'll get bitbucket added.
at least, all plugins that exist should allow here. https://github.com/apache/incubator-devlake/tree/main/plugins
But I think we needn't validate the plugin name in advance mode. Users will check it themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055#issuecomment-1244876027
> > @likyh For the moment, "bitbucket" is new plugin and needs to be added to the list of "Allowed Providers" In Advanced mode. This validation is there to prevent invalid plugins from being manually entered via json.
>
> I think we should allow all name in here. Because maybe user will load his private plugin.
I'll get bitbucket added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3055: [Bug][config-ui] cannot create my plugin by advance mode in config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3055:
URL: https://github.com/apache/incubator-devlake/issues/3055#issuecomment-1258038800
Will turn off validation for now (advanced mode)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org