You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2023/05/08 13:52:04 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
MartijnVisser opened a new pull request, #22546:
URL: https://github.com/apache/flink/pull/22546
## What is the purpose of the change
* Update to flink-shaded 17.0
## Brief change log
* Updated POM files
* Changed all `guava30` occurrences to `guava31` since flink-shaded uses a newer Guava version
* Updated the used `flink-sql-connector-pulsar` to `4.0.0-1.17` since that version doesn't use the shaded Guava version
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1191208612
##########
pom.xml:
##########
@@ -122,8 +122,8 @@ under the License.
<flink.forkCountUnitTest>4</flink.forkCountUnitTest>
<flink.reuseForks>true</flink.reuseForks>
<flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m</flink.surefire.baseArgLine>
- <flink.shaded.version>16.1</flink.shaded.version>
- <flink.shaded.jackson.version>2.13.4</flink.shaded.jackson.version>
Review Comment:
Ah yes, that's what I meant but it doesn't help if I type `4.0` instead of `5.4.0` 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1245119947
##########
flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml:
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>3.0.0-1.17</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-shaded-guava</artifactId>
+ <version>30.1.1-jre-16.1</version>
Review Comment:
shouldn't it be 31.xx ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1245196580
##########
flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml:
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>3.0.0-1.17</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-shaded-guava</artifactId>
+ <version>30.1.1-jre-16.1</version>
Review Comment:
yes, i see...
then would it make sense to have a comment that this version should be in sync with kafka-connector's?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1539541455
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1246344004
##########
flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml:
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>3.0.0-1.17</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-shaded-guava</artifactId>
+ <version>30.1.1-jre-16.1</version>
Review Comment:
I agree - we should add a comment here.
##########
pom.xml:
##########
@@ -353,13 +353,13 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded-netty</artifactId>
- <version>4.1.82.Final-${flink.shaded.version}</version>
+ <version>4.1.91.Final-${flink.shaded.version}</version>
Review Comment:
We initially thought of doing the flink-shaded update early in the release to have enough CI cycles to test the functionality. With the delays we're getting close to the 1.18 feature freeze which contradicts the initial idea of the timing. I discussed this with @zentol: Based on past experience, netty was the source of instabilities. So, if we want to play it safe we could upgrade all the shaded dependencies except for netty and do the netty upgrade in 1.19 early on.
But on the other note: With 2 weeks until the feature freeze (which might be postponed anyway) and additional time for bug fixing and release testing, we still might have enough CI cycles. What's your opinion on that one?
I don't see a reason to not do the upgrade more conservatively (i.e. waiting with the netty upgrade and doing it in a separate ticket). Chesnay things that there is still enough time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1587117565
> @MartijnVisser What's the state of this PR? I guess, we shouldn't wait for it to be merged for too long.
There's a blocker with the JDBC connector also relying on `flink-shaded`. That connector vote first needs to be completed, before this is unblocked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1245123145
##########
flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml:
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>3.0.0-1.17</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-shaded-guava</artifactId>
+ <version>30.1.1-jre-16.1</version>
Review Comment:
From @zentol
```I guess what happens is that in the flink-confluent-schema-registry module we end up pulling in a different version of flink-shaded-guava, since the dependencyManagement entry in the root pom overrules the transitive dependency from Kafka.```
```so, downgrade flink-shaded-guava to whatever kafka needs in that module```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1246399629
##########
pom.xml:
##########
@@ -353,13 +353,13 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded-netty</artifactId>
- <version>4.1.82.Final-${flink.shaded.version}</version>
+ <version>4.1.91.Final-${flink.shaded.version}</version>
Review Comment:
Ok, fine with me - I just wanted to bring this discussion up once. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1559690391
Did you do a rebase onto `master` that includes the FLINK-32056 change? Because the python module is still failing for some reason :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1190804080
##########
pom.xml:
##########
@@ -122,8 +122,8 @@ under the License.
<flink.forkCountUnitTest>4</flink.forkCountUnitTest>
<flink.reuseForks>true</flink.reuseForks>
<flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m</flink.surefire.baseArgLine>
- <flink.shaded.version>16.1</flink.shaded.version>
- <flink.shaded.jackson.version>2.13.4</flink.shaded.jackson.version>
Review Comment:
> I suggest that we keep these two dependencies in sync.
Just to double check, so upgrade to Curator 4.0 as part of the upgrade to flink-shaded 17.0?
If so, can you help with the necessary changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1190878579
##########
pom.xml:
##########
@@ -122,8 +122,8 @@ under the License.
<flink.forkCountUnitTest>4</flink.forkCountUnitTest>
<flink.reuseForks>true</flink.reuseForks>
<flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m</flink.surefire.baseArgLine>
- <flink.shaded.version>16.1</flink.shaded.version>
- <flink.shaded.jackson.version>2.13.4</flink.shaded.jackson.version>
Review Comment:
No, I suggest updating to Curator 5.4.0 because that's what we're using in flink-shaded 17.0. AFAIR, there was only one code location that needs to be updated in [ZooKeeperTestUtils:57](https://github.com/apache/flink/blob/e122dec43edac9a03ef86eeacd02ebb5f429eb70/flink-runtime/src/test/java/org/apache/flink/runtime/testutils/ZooKeeperTestUtils.java#L57). The Integer value needs to be changed to a String (`60_000` becomes `"60000"`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1559719757
> Because the python module is still failing for some reason 🤔
Ah, `flink-connector-jdbc` also uses `flink-shaded` :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1587107100
@MartijnVisser What's the state of this PR? I guess, we shouldn't wait for it to be merged for too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1190804932
##########
pom.xml:
##########
@@ -376,7 +376,7 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded-netty</artifactId>
- <version>4.1.90.Final-${flink.shaded.version}</version>
Review Comment:
I'll change that when I'm rebasing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1543554435
@XComp Thnx for the review. I've decided to split of the upgrade of Pulsar in flink-python from this PR, because it requires more changes. I've filed https://issues.apache.org/jira/browse/FLINK-32056 for that. When that's done and merged, I'll rebase the PR. If you can help with the necessary Curator changes, we can work a bit in parallel I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1610020836
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1246394692
##########
pom.xml:
##########
@@ -353,13 +353,13 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded-netty</artifactId>
- <version>4.1.82.Final-${flink.shaded.version}</version>
+ <version>4.1.91.Final-${flink.shaded.version}</version>
Review Comment:
> With 2 weeks until the feature freeze (which might be postponed anyway) and additional time for bug fixing and release testing, we still might have enough CI cycles. What's your opinion on that one?
I think there's still enough time to actually merge the changes as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1609318605
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1612963587
> Generally, I'm not a big fan of adding things "while merging" because it doesn't show up in the PR which makes it harder investigate issues on `master`
Oh I always add it to the PR, but I don't wait for that CI cycle to fix (only if it's a comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #22546:
URL: https://github.com/apache/flink/pull/22546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1246395062
##########
flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml:
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>3.0.0-1.17</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-shaded-guava</artifactId>
+ <version>30.1.1-jre-16.1</version>
Review Comment:
I'll add a comment when merging :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1559696173
> Did you do a rebase onto `master` that includes the [FLINK-32056](https://issues.apache.org/jira/browse/FLINK-32056) change? Because the python module is still failing for some reason 🤔
I did. I'm suspecting that the Shaded actually breaks something for Python as well, so looking into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1190164832
##########
pom.xml:
##########
@@ -376,7 +376,7 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-shaded-netty</artifactId>
- <version>4.1.90.Final-${flink.shaded.version}</version>
Review Comment:
The commit message doesn't match the change? :thinking:
##########
pom.xml:
##########
@@ -122,8 +122,8 @@ under the License.
<flink.forkCountUnitTest>4</flink.forkCountUnitTest>
<flink.reuseForks>true</flink.reuseForks>
<flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m</flink.surefire.baseArgLine>
- <flink.shaded.version>16.1</flink.shaded.version>
- <flink.shaded.jackson.version>2.13.4</flink.shaded.jackson.version>
Review Comment:
There's also `<curator.version/>` property further down in the file that is used for test code. I suggest that we keep these two dependencies in sync. We would have to change some parameter initialization (see [CURATOR-663](https://issues.apache.org/jira/browse/CURATOR-663)) if we decide to upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1544039275
@XComp I've pushed my changes, even though I know it will fail on the Python part, but wanted to see if everything else passes/is now OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1538408360
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "894f0c0f10e8b85121208b024af4320935b52c27",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "894f0c0f10e8b85121208b024af4320935b52c27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 894f0c0f10e8b85121208b024af4320935b52c27 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22546:
URL: https://github.com/apache/flink/pull/22546#issuecomment-1540301776
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org