You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2018/01/18 22:25:35 UTC
[Impala-ASF-CR] [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9066
Change subject: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
......................................................................
[DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Overlooked the new keyword when the clause was
originally introduced.
Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
---
M docs/topics/impala_reserved_words.xml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/9066/1
--
To view, visit http://gerrit.cloudera.org:8080/9066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Gerrit-Change-Number: 9066
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9066 )
Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Gerrit-Change-Number: 9066
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 21:26:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9066 )
Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/191/
--
To view, visit http://gerrit.cloudera.org:8080/9066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Gerrit-Change-Number: 9066
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 21:17:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9066 )
Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Gerrit-Change-Number: 9066
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 01:27:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9066 )
Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
......................................................................
IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Overlooked the new keyword when the clause was
originally introduced.
Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Reviewed-on: http://gerrit.cloudera.org:8080/9066
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_reserved_words.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Gerrit-Change-Number: 9066
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9066
to look at the new patch set (#2).
Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
......................................................................
IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Overlooked the new keyword when the clause was
originally introduced.
Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
---
M docs/topics/impala_reserved_words.xml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/9066/2
--
To view, visit http://gerrit.cloudera.org:8080/9066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9
Gerrit-Change-Number: 9066
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>