You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/29 02:00:23 UTC
[GitHub] [airflow] ming-zhang-SN opened a new issue, #24721: `default_wrap` setting for webserver is not working
ming-zhang-SN opened a new issue, #24721:
URL: https://github.com/apache/airflow/issues/24721
### Apache Airflow version
2.3.2 (latest released)
### What happened
The DAG logs are not wrapped even I set `default_wrap` in `airflow.cfg` to `True`.
That may cause by this line I think:
https://github.com/apache/airflow/blob/main/airflow/www/static/js/dag_code.js#L25
I tried with the following code and worked:
```
$('pre > code').toggleClass('wrap');
```
### What you think should happen instead
_No response_
### How to reproduce
_No response_
### Operating System
Ubuntu 19.10
### Versions of Apache Airflow Providers
_No response_
### Deployment
Official Apache Airflow Helm Chart
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24721: `default_wrap` setting for webserver is not working
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-1215695420
@pierrejeambrun We may want to make sure this config is passed to the new grid view logs too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24721: `default_wrap` setting for webserver is not working
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-1450438370
If anyone else wants to pick up this issue. You will want to add a meta tag for `wrapped` to the [ti_log html file](https://github.com/apache/airflow/blob/main/airflow/www/templates/airflow/ti_log.html). Then to use `getMetaValue()` to get that value in the js file and add the `wrap` class to the code block [here](https://github.com/apache/airflow/blob/main/airflow/www/static/js/ti_log.js#L123).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #24721: `default_wrap` setting for webserver is not working
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-1215773276
Yes good idea. I'll open a PR for that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `default_wrap` setting for webserver is not working [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-2036344421
This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activity on this issue. Kindly asking to recheck the report against latest Airflow version and let us know if the issue is reproducible. The issue will be closed in next 30 days if no further activity occurs from the issue author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #24721: `default_wrap` setting for webserver is not working
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-1224337921
@ming-zhang-SN do you still want to open a PR to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #24721: `default_wrap` setting for webserver is not working
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #24721:
URL: https://github.com/apache/airflow/issues/24721#issuecomment-1319161114
@ming-zhang-SN We made the update for the grid view, do you want to open a PR for the log page ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org