[GitHub] [cassandra-accord] belliottsmith commented on a diff in pull request #50: State Eviction

["belliottsmith (via GitHub)" <gi...@apache.org>]

belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1227354072


##########
accord-core/src/main/java/accord/local/SaveStatus.java:
##########
@@ -35,30 +35,41 @@
  */
 public enum SaveStatus
 {
-    NotWitnessed                    (Status.NotWitnessed),
+    // TODO (expected): erase Uninitialised in Context once command finishes
+    // TODO (expected): we can use Uninitialised in several places to simplify/better guarantee correct behaviour with truncation
+    Uninitialised                   (Status.NotDefined),
+    NotDefined                      (Status.NotDefined),

Review Comment:
   Uninitialised just means we haven’t yet assigned it any local state - the accessor is the first to access it. This lets us be more relaxed for some accessors. Essentially, you either need to say “give me this command if it already exists, and so I’m not resurrecting a dead command” or “here’s enough information for you to determine that a missing command has been truncated or not”  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org