You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Aniket Mokashi <an...@gmail.com> on 2014/05/14 20:45:40 UTC
Review Request 21454: Pig should use job's jobClient wherever possible
(fixes local mode counters)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21454/
-----------------------------------------------------------
Review request for pig, Daniel Dai, Jonathan Coveney, and Julien Le Dem.
Bugs: PIG-3913
https://issues.apache.org/jira/browse/PIG-3913
Repository: pig
Description
-------
Fixes pig counters by using correct interfaces to poll job counters.
Diffs
-----
trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1591154
trunk/shims/src/hadoop23/org/apache/hadoop/mapred/DowngradeHelper.java PRE-CREATION
trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1591154
trunk/src/org/apache/pig/backend/hadoop/executionengine/Launcher.java 1591154
trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1591154
trunk/src/org/apache/pig/tools/pigstats/InputStats.java 1591154
trunk/src/org/apache/pig/tools/pigstats/JobStats.java 1591154
trunk/src/org/apache/pig/tools/pigstats/OutputStats.java 1591154
trunk/src/org/apache/pig/tools/pigstats/PigStats.java 1591154
trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRJobStats.java 1591154
trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRPigStatsUtil.java 1591154
trunk/src/org/apache/pig/tools/pigstats/mapreduce/SimplePigStats.java 1591154
Diff: https://reviews.apache.org/r/21454/diff/
Testing
-------
Thanks,
Aniket Mokashi
Re: Review Request 21454: Pig should use job's jobClient wherever possible
(fixes local mode counters)
Posted by Aniket Mokashi <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21454/
-----------------------------------------------------------
(Updated May 20, 2014, 5:46 p.m.)
Review request for pig, Daniel Dai, Jonathan Coveney, and Julien Le Dem.
Bugs: PIG-3913
https://issues.apache.org/jira/browse/PIG-3913
Repository: pig
Description
-------
Fixes pig counters by using correct interfaces to poll job counters.
Diffs (updated)
-----
trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1596326
trunk/shims/src/hadoop23/org/apache/hadoop/mapred/DowngradeHelper.java PRE-CREATION
trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1596326
trunk/src/org/apache/pig/backend/hadoop/executionengine/Launcher.java 1596326
trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1596326
trunk/src/org/apache/pig/tools/pigstats/InputStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/JobStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/OutputStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/PigStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRJobStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRPigStatsUtil.java 1596326
trunk/src/org/apache/pig/tools/pigstats/mapreduce/SimplePigStats.java 1596326
Diff: https://reviews.apache.org/r/21454/diff/
Testing
-------
Thanks,
Aniket Mokashi
Re: Review Request 21454: Pig should use job's jobClient wherever possible
(fixes local mode counters)
Posted by Aniket Mokashi <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21454/
-----------------------------------------------------------
(Updated May 20, 2014, 5:45 p.m.)
Review request for pig, Daniel Dai, Jonathan Coveney, and Julien Le Dem.
Bugs: PIG-3913
https://issues.apache.org/jira/browse/PIG-3913
Repository: pig
Description
-------
Fixes pig counters by using correct interfaces to poll job counters.
Diffs (updated)
-----
trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1596326
trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1596326
trunk/src/org/apache/pig/backend/hadoop/executionengine/Launcher.java 1596326
trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1596326
trunk/src/org/apache/pig/tools/pigstats/InputStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/JobStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/OutputStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/PigStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRJobStats.java 1596326
trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRPigStatsUtil.java 1596326
trunk/src/org/apache/pig/tools/pigstats/mapreduce/SimplePigStats.java 1596326
Diff: https://reviews.apache.org/r/21454/diff/
Testing
-------
Thanks,
Aniket Mokashi
Re: Review Request 21454: Pig should use job's jobClient wherever possible
(fixes local mode counters)
Posted by Gera Shegalov <ge...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21454/#review43193
-----------------------------------------------------------
Ship it!
+1 (non-binding) modulo the nits below.
trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java
<https://reviews.apache.org/r/21454/#comment77266>
nit: inconsistent whitespace, although it seems inconsistent most of the time in Pig
trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java
<https://reviews.apache.org/r/21454/#comment77268>
presumably there might be more cases in the future. Please name more explicitly such as:
downgradeTaskReports[Array]
- Gera Shegalov
On May 14, 2014, 6:45 p.m., Aniket Mokashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21454/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 6:45 p.m.)
>
>
> Review request for pig, Daniel Dai, Jonathan Coveney, and Julien Le Dem.
>
>
> Bugs: PIG-3913
> https://issues.apache.org/jira/browse/PIG-3913
>
>
> Repository: pig
>
>
> Description
> -------
>
> Fixes pig counters by using correct interfaces to poll job counters.
>
>
> Diffs
> -----
>
> trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1591154
> trunk/shims/src/hadoop23/org/apache/hadoop/mapred/DowngradeHelper.java PRE-CREATION
> trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java 1591154
> trunk/src/org/apache/pig/backend/hadoop/executionengine/Launcher.java 1591154
> trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/InputStats.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/JobStats.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/OutputStats.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/PigStats.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRJobStats.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRPigStatsUtil.java 1591154
> trunk/src/org/apache/pig/tools/pigstats/mapreduce/SimplePigStats.java 1591154
>
> Diff: https://reviews.apache.org/r/21454/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aniket Mokashi
>
>