[GitHub] [hudi] danny0405 commented on a diff in pull request #5203: [HUDI-2473] Fixing compaction write operation in commit metadata

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5203:
URL: https://github.com/apache/hudi/pull/5203#discussion_r880029542


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/RunCompactionActionExecutor.java:
##########
@@ -81,7 +82,7 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute() {
         metadata.addWriteStat(stat.getPartitionPath(), stat);
       }
       metadata.addMetadata(HoodieCommitMetadata.SCHEMA_KEY, config.getSchema());
-
+      metadata.setOperationType(WriteOperationType.COMPACT);
       compactionMetadata.setWriteStatuses(statuses);
       compactionMetadata.setCommitted(false);

Review Comment:
   Hmm, a very long time, i thought this was a design purpose, the compaction uses the commit action time as COW on the timeline, we can also see this as a bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org