Re: svn commit: r613230 - in /activemq/trunk/activemq-core/src/main/java/org/apache/activemq: advisory/ broker/region/ broker/region/policy/

[Rob Davies <ra...@gmail.com>]

On Jan 22, 2008, at 2:22 AM, Glen Mazza wrote:

> Am Freitag, den 18.01.2008, 19:16 +0000 schrieb rajdavies@apache.org:
>> Author: rajdavies
>> Date: Fri Jan 18 11:16:15 2008
>> New Revision: 613230
>>
>
>> Modified:
>> activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ 
>> broker/region/BaseDestination.java
>> URL:
>> http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/BaseDestination.java?rev=613230&r1=613229&r2=613230&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> +    public ActiveMQDestination getActiveMQDestination() {
>> +        return destination;
>> +    }
>> +
>> +    public final String getDestination() {
>> +        return destination.getPhysicalName();
>> +    }
>> +
>
> The method above is the same as getName() below (and also somewhat
> confusing, as it gives the impression it returns a Destination  
> object).
> It should probably be removed.
>
>
>> +    public final String getName() {
>> +        return getActiveMQDestination().getPhysicalName();
>> +    }
>> +
>
> Regards,
> Glen
>
>

Yes - agreed - it is confusing

cheers,

Rob



Rob Davies
'Go further faster with Apache Camel!'
http://rajdavies.blogspot.com/