You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mjsax <gi...@git.apache.org> on 2015/06/25 03:07:48 UTC
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/866
[FLINK-2275] Migrate test from package 'org.apache.flink.test.javaApiOperators'
migrated test from execute() to collect()
subtask of https://issues.apache.org/jira/browse/FLINK-2032
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-2275-migrateFlinkTests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/866.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #866
----
commit 120c4eaea232b8f66e48fa8eca95caddb74a0510
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-06-24T23:49:23Z
migrated test from execute() to collect()
- for package 'org.apache.flink.test.javaApiOperators'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115652087
All in all this looks good.
The only think that strikes me is the of the test pattern(that way used also before by the tests. I am not a big fan of validating results in an `@After` method. I find the tests more readable if they simply call the comparison themselves at the end:
```java
List<Tuple2<String, Integer>> result = data.collect()
String expected = "Hello,2\n" +
"Dude,5\n"
compareResultAsTuples(expexted, result)
```
This also solves the issue with the raw type lists, which is usually an indicator that something is not modeled in the right way (unless you dynamically load or instantiate types).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-116077164
@gyfora re-enabled a disabled Kafka test in this pull request: https://github.com/apache/flink/pull/747/files
The test is known to be unstable, thats why I disabled it for the time being. Can you disable it again in your PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/866
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-116165324
Done. If Travis is green, please merge. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115173704
I adapted all tests except for DataSinkITCase and ExecutionEnvironmentITCase.
- DataSinkITCase -> seems to test writing to file explicit; would not make sense to change it (tell me, if I am wrong)
- ExecutionEnvironmentITCase ->uses LocalCollectionOutputFormat, and is not writing to disc already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-117684978
Looks good, let me merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-116060075
Done. Failing tests revile a Kafka problem (in my Travis, too https://travis-ci.org/mjsax/flink/builds/68598571). Is it known? Module flink-tests passed in all runs.
Should be ready to get merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-116106232
Sorry about re-enabling the failing test, I completely missed it...
Matthias please @ignore it :P
Btw @rmetzger do we have a JIRA for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115662194
I agree. I just did not want to change the current pattern... However, we should do it the right way in this PR, too. I will update the code accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2275] Migrate test from package 'org.ap...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115652174
This comment is not a blocker for merging this. Let's just not write future tests like this, and whenever we touch something, we could on-the-fly migrate the tests to not follow this pattern any more...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---